fix(LabelsDataSource): Limit the maximum number of concurrent requests to fetch label values (#165)

Author: grafakus

package.json

@@ -52,6 +52,7 @@
  "file-saver": "^2.0.5",
  "markdown-to-jsx": "^7.3.2",
  "nanoid": "^4.0.2",
+ "p-limit": "^6.1.0",
  "protobufjs": "^7.2.6",
  "react": "18.2.0",
  "react-dom": "18.2.0",

src/pages/ProfilesExplorerView/infrastructure/labels/LabelsDataSource.ts

@@ -10,12 +10,16 @@ import {
 import { RuntimeDataSource, sceneGraph } from '@grafana/scenes';
 import { isPrivateLabel } from '@shared/components/QueryBuilder/domain/helpers/isPrivateLabel';
 import { labelsRepository } from '@shared/infrastructure/labels/labelsRepository';
+import pLimit from 'p-limit';
 
 import { GroupByVariable } from '../../domain/variables/GroupByVariable/GroupByVariable';
 import { computeRoundedTimeRange } from '../../helpers/computeRoundedTimeRange';
 import { PYROSCOPE_LABELS_DATA_SOURCE } from '../pyroscope-data-sources';
 import { LabelsApiClient } from './http/LabelsApiClient';
 
+const MAX_CONCURRENT_LABEL_VALUES_REQUESTS = 20;
+const limit = pLimit(MAX_CONCURRENT_LABEL_VALUES_REQUESTS);
+
 export class LabelsDataSource extends RuntimeDataSource {
  static MAX_TIMESERIES_LABEL_VALUES = 10;
 
@@ -91,34 +95,32 @@ export class LabelsDataSource extends RuntimeDataSource {
 
  labelsRepository.setApiClient(new LabelsApiClient({ dataSourceUid }));
 
- const labels = await labelsRepository.listLabels({ query, from, to });
-
- const sortedLabelsWithCounts = (
- await Promise.all(
- labels
- .filter(({ value }) => !isPrivateLabel(value))
- .sort((a, b) => a.label.localeCompare(b.label))
- .map(async ({ value }) => {
- const values = (await labelsRepository.listLabelValues({ query, from, to, label: value })).map(
- ({ value }) => value
- );
- const count = values.length;
-
- return {
- // TODO: check if there's a better way
- value: JSON.stringify({
- value,
- groupBy: {
- label: value,
- values,
- },
- }),
- text: `${value} (${count})`,
- count,
- };
- })
+ const labels = (await labelsRepository.listLabels({ query, from, to })).filter(
+ ({ value }) => !isPrivateLabel(value)
+ );
+
+ const labelsWithValuesAndCount = await Promise.all(
+ labels.map(({ value }) =>
+ limit(async () => {
+ const values = await labelsRepository.listLabelValues({ query, from, to, label: value });
+ const count = values.length;
+ return {
+ // TODO: check if there's a better way
+ value: JSON.stringify({
+ value,
+ groupBy: {
+ label: value,
+ values,
+ },
+ }),
+ text: `${value} (${count})`,
+ count,
+ };
+ })
  )
- )
+ );
+
+ const sortedLabels = labelsWithValuesAndCount
  .sort((a, b) => b.count - a.count)
  .map(({ value, text }) => ({ value, text }));
 
@@ -128,7 +130,7 @@ export class LabelsDataSource extends RuntimeDataSource {
  value: 'all',
  text: 'All',
  },
- ...sortedLabelsWithCounts,
+ ...sortedLabels,
  ];
  }
 

yarn.lock

@@ -9998,6 +9998,15 @@ __metadata:
  languageName: node
  linkType: hard
 
+"p-limit@npm:^6.1.0":
+ version: 6.1.0
+ resolution: "p-limit@npm:6.1.0"
+ dependencies:
+ yocto-queue: "npm:^1.1.1"
+ checksum: 10/9670cb4426d77c20a477cad0e44e8207248381135650f5b9bfe039c9d93566cd4b05cfc557fe60f2db88c799991c7edc6be436255d287a87a605ee604a71cd91
+ languageName: node
+ linkType: hard
+
 "p-locate@npm:^4.1.0":
  version: 4.1.0
  resolution: "p-locate@npm:4.1.0"
@@ -10581,6 +10590,7 @@ __metadata:
  lint-staged: "npm:^15.0.2"
  markdown-to-jsx: "npm:^7.3.2"
  nanoid: "npm:^4.0.2"
+ p-limit: "npm:^6.1.0"
  prettier: "npm:^2.5.0"
  prettier-package-json: "npm:^2.8.0"
  protobufjs: "npm:^7.2.6"
@@ -14054,6 +14064,13 @@ __metadata:
  languageName: node
  linkType: hard
 
+"yocto-queue@npm:^1.1.1":
+ version: 1.1.1
+ resolution: "yocto-queue@npm:1.1.1"
+ checksum: 10/f2e05b767ed3141e6372a80af9caa4715d60969227f38b1a4370d60bffe153c9c5b33a862905609afc9b375ec57cd40999810d20e5e10229a204e8bde7ef255c
+ languageName: node
+ linkType: hard
+
 "zone.js@npm:^0.11.0":
  version: 0.11.8
  resolution: "zone.js@npm:0.11.8"