Skip to content

Commit bb0a350

Browse files
d-googsofisl
andauthored
chore(Node.js): Update PR Template (#2059)
* feat: Update PR Template * docs: Update synthtool/gcp/templates/node_library/.github/PULL_REQUEST_TEMPLATE.md Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> * docs: Update synthtool/gcp/templates/node_library/.github/PULL_REQUEST_TEMPLATE.md Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> --------- Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
1 parent 450363b commit bb0a350

File tree

3 files changed

+80
-15
lines changed

3 files changed

+80
-15
lines changed
Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,30 @@
1-
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2-
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/{{ metadata['repo']['repo'] }}/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
1+
> Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2+
3+
## Description
4+
5+
> Please provide a detailed description for the change.
6+
> As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.
7+
8+
## Impact
9+
10+
> What's the impact of this change?
11+
12+
## Testing
13+
14+
> Have you added unit and integration tests if necessary?
15+
> Were any tests changed? Are any breaking changes necessary?
16+
17+
## Additional Information
18+
19+
> Any additional details that we should be aware of?
20+
21+
## Checklist
22+
23+
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/{{ metadata['repo']['repo'] }}/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
324
- [ ] Ensure the tests and linter pass
4-
- [ ] Code coverage does not decrease (if any source code was changed)
5-
- [ ] Appropriate docs were updated (if necessary)
25+
- [ ] Code coverage does not decrease
26+
- [ ] Appropriate docs were updated
27+
- [ ] Appropriate comments were added, particularly in complex areas or places that require background
28+
- [ ] No new warnings or issues will be generated from this change
629

7-
Fixes #<issue_number_goes_here> 🦕
30+
Fixes #issue_number_goes_here 🦕
Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,28 @@
1-
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2-
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-dlp/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
1+
> Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2+
3+
## Description
4+
5+
> Please provide a detailed description for the change.
6+
7+
## Impact
8+
9+
> What's the impact of this change?
10+
11+
## Testing
12+
13+
> What testing have you performed or added for this pull request?
14+
15+
## Additional Information
16+
17+
> Any additional details that we should be aware of?
18+
19+
## Checklist
20+
21+
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/{{ metadata['repo']['repo'] }}/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
322
- [ ] Ensure the tests and linter pass
4-
- [ ] Code coverage does not decrease (if any source code was changed)
5-
- [ ] Appropriate docs were updated (if necessary)
23+
- [ ] Code coverage does not decrease
24+
- [ ] Appropriate docs were updated
25+
- [ ] Appropriate comments were added, particularly in complex areas or places that require background
26+
- [ ] No new warnings or issues will be generated from this change
627

7-
Fixes #<issue_number_goes_here> 🦕
28+
Fixes #issue_number_goes_here 🦕
Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,28 @@
1-
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2-
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-dlp/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
1+
> Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2+
3+
## Description
4+
5+
> Please provide a detailed description for the change.
6+
7+
## Impact
8+
9+
> What's the impact of this change?
10+
11+
## Testing
12+
13+
> What testing have you performed or added for this pull request?
14+
15+
## Additional Information
16+
17+
> Any additional details that we should be aware of?
18+
19+
## Checklist
20+
21+
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/{{ metadata['repo']['repo'] }}/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
322
- [ ] Ensure the tests and linter pass
4-
- [ ] Code coverage does not decrease (if any source code was changed)
5-
- [ ] Appropriate docs were updated (if necessary)
23+
- [ ] Code coverage does not decrease
24+
- [ ] Appropriate docs were updated
25+
- [ ] Appropriate comments were added, particularly in complex areas or places that require background
26+
- [ ] No new warnings or issues will be generated from this change
627

7-
Fixes #<issue_number_goes_here> 🦕
28+
Fixes #issue_number_goes_here 🦕

0 commit comments

Comments
 (0)