Skip to content

Commit 3b7bb40

Browse files
authored
[ggj][bazel] fix: add google/type:type_java_proto as default test dep (#571)
* fix: handle empty method_signature in parsing protos * fix: add google/type:type_java_proto as default test dep
1 parent b0a8ba8 commit 3b7bb40

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

rules_java_gapic/java_gapic.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ def java_gapic_library(
197197

198198
# Test deps.
199199
actual_test_deps = test_deps + actual_deps + [
200+
"@com_google_googleapis//google/type:type_java_proto", # Commonly used.
200201
"@com_google_api_gax_java//gax-grpc:gax_grpc_testlib",
201202
"@com_google_api_gax_java//gax:gax_testlib",
202203
"@com_google_code_gson_gson//jar",

test/integration/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ java_gapic_library(
5555
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
5656
"@com_google_googleapis//google/iam/v1:iam_java_proto",
5757
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_proto",
58-
"@com_google_googleapis//google/type:type_java_proto",
5958
],
6059
)
6160

@@ -75,7 +74,6 @@ java_gapic_assembly_gradle_pkg(
7574
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
7675
"@com_google_googleapis//google/cloud/asset/v1:asset_proto",
7776
"@com_google_googleapis//google/cloud/orgpolicy/v1:orgpolicy_java_proto",
78-
"@com_google_googleapis//google/identity/accesscontextmanager/type:type_java_proto",
7977
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_java_proto",
8078
],
8179
)

0 commit comments

Comments
 (0)