fix: Remove default_ad_break_duration from LiveConfig (#145)

* feat!: Update LRO metadata type to google.cloud.common.OperationMetadata BREAKING CHANGE PiperOrigin-RevId: 520405218 Source-Link: googleapis/googleapis@4931d1b Source-Link: https://github.com/googleapis/googleapis-gen/commit/dd1f11489e32e15ba5a5b1a76e2b8f4748c6c1d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGQxZjExNDg5ZTMyZTE1YmE1YTViMWE3NmUyYjhmNDc0OGM2YzFkOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat!: Remove default_ad_break_duration from LiveConfig BREAKING CHANGE PiperOrigin-RevId: 520434307 Source-Link: googleapis/googleapis@273994f Source-Link: https://github.com/googleapis/googleapis-gen/commit/49986a12fef4f0ed9b200228347e3f5d280cc72f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDk5ODZhMTJmZWY0ZjBlZDliMjAwMjI4MzQ3ZTNmNWQyODBjYzcyZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix!: Roll back the changes that update of LRO metadata type to google.cloud.common.OperationMetadata PiperOrigin-RevId: 520464508 Source-Link: googleapis/googleapis@cf01552 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5a981d622d237b05476086408ec523ff4b7c0600 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWE5ODFkNjIyZDIzN2IwNTQ3NjA4NjQwOGVjNTIzZmY0YjdjMDYwMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat!: introduce GAM settings for GAM related configs and support ListOperations PiperOrigin-RevId: 524328971 Source-Link: googleapis/googleapis@a5f8761 Source-Link: https://github.com/googleapis/googleapis-gen/commit/6414e5e4aa4eb9de399b3b5f36c9d1640ebcd07a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjQxNGU1ZTRhYTRlYjlkZTM5OWIzYjVmMzZjOWQxNjQwZWJjZDA3YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Author: gcf-owl-bot[bot]

google/cloud/video/stitcher/__init__.py

@@ -52,7 +52,6 @@
  PrefetchConfig,
 )
 from google.cloud.video.stitcher_v1.types.sessions import (
- GamVodConfig,
  Interstitials,
  LiveSession,
  ManifestOptions,
@@ -124,7 +123,6 @@
  "LiveConfig",
  "PrefetchConfig",
  "AdTracking",
- "GamVodConfig",
  "Interstitials",
  "LiveSession",
  "ManifestOptions",

google/cloud/video/stitcher_v1/__init__.py

@@ -40,7 +40,6 @@
 from .types.events import Event, ProgressEvent
 from .types.live_configs import AdTracking, GamLiveConfig, LiveConfig, PrefetchConfig
 from .types.sessions import (
- GamVodConfig,
  Interstitials,
  LiveSession,
  ManifestOptions,
@@ -105,7 +104,6 @@
  "DeleteSlateRequest",
  "Event",
  "GamLiveConfig",
- "GamVodConfig",
  "GetCdnKeyRequest",
  "GetLiveAdTagDetailRequest",
  "GetLiveConfigRequest",

google/cloud/video/stitcher_v1/services/video_stitcher_service/async_client.py

@@ -45,7 +45,6 @@
 from google.api_core import operation # type: ignore
 from google.api_core import operation_async # type: ignore
 from google.longrunning import operations_pb2
-from google.protobuf import duration_pb2 # type: ignore
 from google.protobuf import empty_pb2 # type: ignore
 from google.protobuf import field_mask_pb2 # type: ignore
 

google/cloud/video/stitcher_v1/services/video_stitcher_service/client.py

@@ -49,7 +49,6 @@
 from google.api_core import operation # type: ignore
 from google.api_core import operation_async # type: ignore
 from google.longrunning import operations_pb2
-from google.protobuf import duration_pb2 # type: ignore
 from google.protobuf import empty_pb2 # type: ignore
 from google.protobuf import field_mask_pb2 # type: ignore
 

google/cloud/video/stitcher_v1/types/__init__.py

@@ -31,7 +31,6 @@
 from .events import Event, ProgressEvent
 from .live_configs import AdTracking, GamLiveConfig, LiveConfig, PrefetchConfig
 from .sessions import (
- GamVodConfig,
  Interstitials,
  LiveSession,
  ManifestOptions,
@@ -98,7 +97,6 @@
  "LiveConfig",
  "PrefetchConfig",
  "AdTracking",
- "GamVodConfig",
  "Interstitials",
  "LiveSession",
  "ManifestOptions",

google/cloud/video/stitcher_v1/types/live_configs.py

@@ -32,13 +32,13 @@
 
 
 class AdTracking(proto.Enum):
- r"""Determines the Ad tracking policy.
+ r"""Determines the ad tracking policy.
 
  Values:
  AD_TRACKING_UNSPECIFIED (0):
  The ad tracking policy is not specified.
  CLIENT (1):
- Client side ad tracking is specified. The
+ Client-side ad tracking is specified. The
  client player is expected to trigger playback
  and activity events itself.
  SERVER (2):
@@ -70,27 +70,21 @@ class LiveConfig(proto.Message):
  state (google.cloud.video.stitcher_v1.types.LiveConfig.State):
  Output only. State of the live config.
  ad_tracking (google.cloud.video.stitcher_v1.types.AdTracking):
- Required. Determines how the ads should be tracked. If
+ Required. Determines how the ads are tracked. If
  [gam_live_config][google.cloud.video.stitcher.v1.LiveConfig.gam_live_config]
  is set, the value must be ``CLIENT`` because the IMA SDK
  handles ad tracking.
  default_slate (str):
- This must refer to a slate in the same
- project. In case Google Ad Manager (GAM) is
- being used for ads this will be used to set the
- appropriate value of slateCreativeId in
+ This must refer to a slate in the same project. If Google Ad
+ Manager (GAM) is used for ads, this string sets the value of
+ ``slateCreativeId`` in
  https://developers.google.com/ad-manager/api/reference/v202211/LiveStreamEventService.LiveStreamEvent#slateCreativeId
  stitching_policy (google.cloud.video.stitcher_v1.types.LiveConfig.StitchingPolicy):
  Defines the stitcher behavior in case an ad does not align
  exactly with the ad break boundaries. If not specified, the
  default is ``CUT_CURRENT``.
  prefetch_config (google.cloud.video.stitcher_v1.types.PrefetchConfig):
  The configuration for prefetching ads.
- default_ad_break_duration (google.protobuf.duration_pb2.Duration):
- The default ad pod duration in seconds that
- will be requested when a cue-out does not
- specify a duration. The default value of this
- field is 30s.
  """
 
  class State(proto.Enum):
@@ -114,7 +108,7 @@ class State(proto.Enum):
  class StitchingPolicy(proto.Enum):
  r"""Defines the ad stitching behavior in case the ad duration does not
  align exactly with the ad break boundaries. If not specified, the
- default is CUT_CURRENT.
+ default is ``CUT_CURRENT``.
 
  Values:
  STITCHING_POLICY_UNSPECIFIED (0):
@@ -171,11 +165,6 @@ class StitchingPolicy(proto.Enum):
  number=10,
  message="PrefetchConfig",
  )
- default_ad_break_duration: duration_pb2.Duration = proto.Field(
- proto.MESSAGE,
- number=11,
- message=duration_pb2.Duration,
- )
 
 
 class PrefetchConfig(proto.Message):

google/cloud/video/stitcher_v1/types/sessions.py

@@ -25,7 +25,6 @@
 __protobuf__ = proto.module(
  package="google.cloud.video.stitcher.v1",
  manifest={
- "GamVodConfig",
  "VodSession",
  "Interstitials",
  "VodSessionAd",
@@ -38,28 +37,6 @@
 )
 
 
-class GamVodConfig(proto.Message):
- r"""Metadata for registering a VOD Session with Google Ad Manager
- (GAM).
-
- Attributes:
- network_code (str):
- Required. Ad Manager network code.
- stream_id (str):
- Required. The stream ID generated by Ad
- Manager.
- """
-
- network_code: str = proto.Field(
- proto.STRING,
- number=1,
- )
- stream_id: str = proto.Field(
- proto.STRING,
- number=2,
- )
-
-
 class VodSession(proto.Message):
  r"""Metadata for a VOD session. The session expires 4 hours after
  its creation.
@@ -103,12 +80,32 @@ class VodSession(proto.Message):
  [gam_vod_config][google.cloud.video.stitcher.v1.VodSession.gam_vod_config]
  is set, the value must be ``CLIENT`` because the IMA SDK
  handles ad tracking.
- gam_vod_config (google.cloud.video.stitcher_v1.types.GamVodConfig):
- This has the Google Ad Manager (GAM) related
- metadata in the case where GAM is used for the
- ads.
+ gam_settings (google.cloud.video.stitcher_v1.types.VodSession.GamSettings):
+ This field should be set with appropriate
+ values if GAM is being used for ads.
  """
 
+ class GamSettings(proto.Message):
+ r"""Defines fields related to Google Ad Manager (GAM). This
+ should be set if GAM is being used for ads.
+
+ Attributes:
+ network_code (str):
+ Required. Ad Manager network code.
+ stream_id (str):
+ Required. The stream ID generated by Ad
+ Manager.
+ """
+
+ network_code: str = proto.Field(
+ proto.STRING,
+ number=1,
+ )
+ stream_id: str = proto.Field(
+ proto.STRING,
+ number=2,
+ )
+
  name: str = proto.Field(
  proto.STRING,
  number=1,
@@ -149,10 +146,10 @@ class VodSession(proto.Message):
  number=11,
  enum=live_configs.AdTracking,
  )
- gam_vod_config: "GamVodConfig" = proto.Field(
+ gam_settings: GamSettings = proto.Field(
  proto.MESSAGE,
- number=12,
- message="GamVodConfig",
+ number=13,
+ message=GamSettings,
  )
 
 
@@ -313,60 +310,12 @@ class GamSettings(proto.Message):
  should be set if GAM
  is being used for ads.
 
- This message has `oneof`_ fields (mutually exclusive fields).
- For each oneof, at most one member field can be set at the same time.
- Setting any member of the oneof automatically clears all other
- members.
-
- .. _oneof: https://proto-plus-python.readthedocs.io/en/stable/fields.html#oneofs-mutually-exclusive-fields
-
  Attributes:
- gam_hls (google.cloud.video.stitcher_v1.types.LiveSession.GamSettings.GamHls):
- Fields that are specific to HLS manifests.
-
- This field is a member of `oneof`_ ``manifest_fields``.
- gam_dash (google.cloud.video.stitcher_v1.types.LiveSession.GamSettings.GamDash):
- Fields that are specific to DASH manifests.
-
- This field is a member of `oneof`_ ``manifest_fields``.
  stream_id (str):
  Required. The stream ID generated by Ad
  Manager.
  """
 
- class GamHls(proto.Message):
- r"""GamHls is a container for any HLS specific input fields for
- GAM Live Stitching.
-
- """
-
- class GamDash(proto.Message):
- r"""GamDash is a container for any DASH specific input fields for
- GAM Live Stitching.
-
- Attributes:
- period_template_uri (str):
- Required. The session template url by Ad
- Manager for DASH periods.
- """
-
- period_template_uri: str = proto.Field(
- proto.STRING,
- number=1,
- )
-
- gam_hls: "LiveSession.GamSettings.GamHls" = proto.Field(
- proto.MESSAGE,
- number=2,
- oneof="manifest_fields",
- message="LiveSession.GamSettings.GamHls",
- )
- gam_dash: "LiveSession.GamSettings.GamDash" = proto.Field(
- proto.MESSAGE,
- number=3,
- oneof="manifest_fields",
- message="LiveSession.GamSettings.GamDash",
- )
  stream_id: str = proto.Field(
  proto.STRING,
  number=1,

google/cloud/video/stitcher_v1/types/slates.py

@@ -39,7 +39,7 @@ class Slate(proto.Message):
  slate. This URI must return an MP4 video with at
  least one audio track.
  gam_slate (google.cloud.video.stitcher_v1.types.Slate.GamSlate):
- gam_slate has all the GAM related attributes of slates.
+ gam_slate has all the GAM-related attributes of slates.
  """
 
  class GamSlate(proto.Message):

samples/generated_samples/snippet_metadata_google.cloud.video.stitcher.v1.json

@@ -8,7 +8,7 @@
  ],
  "language": "PYTHON",
  "name": "google-cloud-video-stitcher",
- "version": "0.7.0"
+ "version": "0.1.0"
  },
  "snippets": [
  {