Skip to content
This repository was archived by the owner on Nov 21, 2023. It is now read-only.

Commit f010478

Browse files
fix: Add async context manager return types (#167)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b3f18d0f6560a855022fd058865e7620479d7af9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 532e521 commit f010478

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

google/cloud/video/live_stream_v1/services/livestream_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2567,7 +2567,7 @@ async def list_locations(
25672567
# Done; return the response.
25682568
return response
25692569

2570-
async def __aenter__(self):
2570+
async def __aenter__(self) -> "LivestreamServiceAsyncClient":
25712571
return self
25722572

25732573
async def __aexit__(self, exc_type, exc, tb):

google/cloud/video/live_stream_v1/services/livestream_service/transports/rest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2585,7 +2585,7 @@ def __call__(
25852585
request_kwargs = json_format.MessageToDict(request)
25862586
transcoded_request = path_template.transcode(http_options, **request_kwargs)
25872587

2588-
body = json.loads(json.dumps(transcoded_request["body"]))
2588+
body = json.dumps(transcoded_request["body"])
25892589
uri = transcoded_request["uri"]
25902590
method = transcoded_request["method"]
25912591

samples/generated_samples/snippet_metadata_google.cloud.video.livestream.v1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-video-live-stream",
11-
"version": "1.4.0"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

tests/unit/gapic/live_stream_v1/test_livestream_service.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,9 +1412,11 @@ async def test_list_channels_async_pages():
14121412
RuntimeError,
14131413
)
14141414
pages = []
1415-
async for page_ in (
1415+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1416+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1417+
async for page_ in ( # pragma: no branch
14161418
await client.list_channels(request={})
1417-
).pages: # pragma: no branch
1419+
).pages:
14181420
pages.append(page_)
14191421
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
14201422
assert page_.raw_page.next_page_token == token
@@ -3232,9 +3234,11 @@ async def test_list_inputs_async_pages():
32323234
RuntimeError,
32333235
)
32343236
pages = []
3235-
async for page_ in (
3237+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3238+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3239+
async for page_ in ( # pragma: no branch
32363240
await client.list_inputs(request={})
3237-
).pages: # pragma: no branch
3241+
).pages:
32383242
pages.append(page_)
32393243
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
32403244
assert page_.raw_page.next_page_token == token
@@ -3966,7 +3970,6 @@ def test_create_event(request_type, transport: str = "grpc"):
39663970
name="name_value",
39673971
execute_now=True,
39683972
state=resources.Event.State.SCHEDULED,
3969-
input_switch=resources.Event.InputSwitchTask(input_key="input_key_value"),
39703973
)
39713974
response = client.create_event(request)
39723975

@@ -4615,9 +4618,11 @@ async def test_list_events_async_pages():
46154618
RuntimeError,
46164619
)
46174620
pages = []
4618-
async for page_ in (
4621+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
4622+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
4623+
async for page_ in ( # pragma: no branch
46194624
await client.list_events(request={})
4620-
).pages: # pragma: no branch
4625+
).pages:
46214626
pages.append(page_)
46224627
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
46234628
assert page_.raw_page.next_page_token == token
@@ -4647,7 +4652,6 @@ def test_get_event(request_type, transport: str = "grpc"):
46474652
name="name_value",
46484653
execute_now=True,
46494654
state=resources.Event.State.SCHEDULED,
4650-
input_switch=resources.Event.InputSwitchTask(input_key="input_key_value"),
46514655
)
46524656
response = client.get_event(request)
46534657

@@ -9265,7 +9269,6 @@ def test_create_event_rest(request_type):
92659269
name="name_value",
92669270
execute_now=True,
92679271
state=resources.Event.State.SCHEDULED,
9268-
input_switch=resources.Event.InputSwitchTask(input_key="input_key_value"),
92699272
)
92709273

92719274
# Wrap the value into a proper Response obj
@@ -9943,7 +9946,6 @@ def test_get_event_rest(request_type):
99439946
name="name_value",
99449947
execute_now=True,
99459948
state=resources.Event.State.SCHEDULED,
9946-
input_switch=resources.Event.InputSwitchTask(input_key="input_key_value"),
99479949
)
99489950

99499951
# Wrap the value into a proper Response obj

0 commit comments

Comments
 (0)