Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 7, 2021

Also, actually test those minimum versions using constraints file.

Closes #494

Also, actually test those minimum versions using constraints file. Closes #494
@tseaver tseaver requested review from a team, busunkim96, chrisrossi and tswast July 7, 2021 20:10
@tseaver tseaver requested a review from a team as a code owner July 7, 2021 20:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 7, 2021
@tseaver tseaver requested review from andrewsg and frankyn July 8, 2021 16:29
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the constraints tests!

@tseaver tseaver merged commit 92251a5 into master Jul 8, 2021
@tseaver tseaver deleted the 494-use-testing-constraints branch July 8, 2021 21:30
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#496) Also, actually test those minimum versions using constraints file. Closes googleapis#494
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#496) Also, actually test those minimum versions using constraints file. Closes googleapis#494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

2 participants