fix: apply idempotency policies for ACLs #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Per idempotency policy.
Per idempotency polixy.
Per idempotency polity.
Per idempotency policy.
Per idempotency policy.
Per idempotency policy.
Per idempotency policy.
tseaver added the priority: p1 
product-auto-label bot added the api: storage 
google-cla bot added the cla: yes 
andrewsg requested changes Jun 8, 2021
Closed
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
* fix: use 'retry=None' as default for 'Client._put_resource' * fix: use 'retry=None' as default for 'Client._patch_resource' * fix: force 'retry=None' for 'ACL.{save,save_predefined,clear}' * fix: remove 'retry' arg from 'Bucket.make_public' * fix: remove 'retry' arg from 'Bucket.make_private' * fix: remove 'retry' arg from 'Blob.make_public' * fix: remove 'retry' arg from 'Blob.make_private' Per idempotency policy. cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
* fix: use 'retry=None' as default for 'Client._put_resource' * fix: use 'retry=None' as default for 'Client._patch_resource' * fix: force 'retry=None' for 'ACL.{save,save_predefined,clear}' * fix: remove 'retry' arg from 'Bucket.make_public' * fix: remove 'retry' arg from 'Bucket.make_private' * fix: remove 'retry' arg from 'Blob.make_public' * fix: remove 'retry' arg from 'Blob.make_private' Per idempotency policy. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Toward #38.
Noneas default retry forClient._patch_resourceandClient._put_resourcehelpers (they can only be idempotent conditionally, so the caller needs to configure the retry).retryargument fromACL.save,ACL.save_predefined, andACL.clear(ACLs cannot be saved idempotently).retryargument fromBucket.make_public,Bucket.make_private,Blob.make_public, andBlob.make_private, which only perform saves on ACLs.