Skip to content

Conversation

@Pulkit0110
Copy link
Member

This PR aims to fix the flaky system tests for resumable media

@Pulkit0110 Pulkit0110 requested review from a team as code owners October 28, 2025 10:46
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 28, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 28, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves flakiness in the resumable_media system tests by adapting the MD5 hash generation logic to be compatible with Python 3.9 and later. The change involves conditionally adding the usedforsecurity=False argument to hashlib.md5 calls, ensuring that tests run consistently across different Python versions without encountering errors related to the updated hashlib behavior.

Highlights

  • Python Version Compatibility: Introduced conditional logic to MD5 hash calculations to ensure compatibility with Python 3.9 and newer versions, which require the usedforsecurity=False parameter for hashlib.md5 when not used for cryptographic security.
  • Test Stability: Addressed flakiness in system tests for resumable_media by updating how MD5 hashes are generated, specifically for empty or general data, to prevent failures on newer Python environments.
  • Module Imports: Added the sys module import to both test_download.py and test_upload.py to facilitate Python version checking.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses flaky system tests for resumable media by updating the usage of hashlib.md5 to be compatible with Python 3.9+ in FIPS-enabled environments. The changes correctly add the usedforsecurity=False parameter when running on newer Python versions. My review includes suggestions to make the implementation more concise and reduce repetition. Overall, the fix is correct and well-targeted.

Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 28, 2025
@Pulkit0110 Pulkit0110 merged commit 7fee3dd into googleapis:main Oct 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

3 participants