fix: do not spam the log with checksum related INFO messages when downloading using transfer_manager #1357
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
download_chunks_concurrentlyfunction does not allow to setchecksumfield indownload_kwargs. It also does not set it on its own so it takes the default value of"md5"(seeBlob._prep_and_do_download). Because ranged downloads do not return checksums it results in a lot of INFO messages (tens/hundreds):To fix it set the
checksumfield toNonewhich means no checksum checking for individual chunks. Note thattransfer_managerhas its own checksum checking logic (enabled bycrc32c_checksumargument)Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1358 🦕