feat: support transaction isolation level in dbapi #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
Adds API arguments and functions for setting a default isolation level and an isolation level per transaction. Support for specifying the isolation level using SQL commands will be added in a follow-up PR.
olavloite force-pushed the dbapi-isolation-level branch from fb43fd6 to 82d15ba Compare 
olavloite requested review from harshachinta and surbhigarg92 and removed request for harshachinta 
surbhigarg92 approved these changes Apr 1, 2025
surbhigarg92 reviewed Apr 1, 2025
| @@ -421,6 +455,7 @@ def begin(self): | |||
| "is already running" | |||
| ) | |||
| self._transaction_begin_marked = True | |||
| self._transaction_isolation_level = isolation_level | |||
There was a problem hiding this comment.
Shouldn't _transaction_isolation_level fallback to isolation_level set at the connection if isolation_level is not provided in begin method ?
There was a problem hiding this comment.
Yes, but we do that at a slightly later moment when the transaction is actually being created here:
The reason for doing it like this is that this allows us to support a statement like set transaction isolation level repeatable read even after calling begin. (We don't support this yet in dbapi as it is part of the PostgreSQL dialect, but we do support this in for example JDBC).
The use of the default from the connection is covered by this test case:
currantw pushed a commit to currantw/google-cloud-spanner-python that referenced this pull request Apr 8, 2025
Adds API arguments and functions for setting a default isolation level and an isolation level per transaction. Support for specifying the isolation level using SQL commands will be added in a follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds API arguments and functions for setting a default isolation level and an
isolation level per transaction.
Support for specifying the isolation level using SQL commands will be added
in a follow-up PR.