feat: snapshot isolation #1318
feat: snapshot isolation #1318
Conversation
product-auto-label bot added size: m 
surbhigarg92 force-pushed the snapshot_isolation branch 2 times, most recently from a300f1e to 44e0104 Compare product-auto-label bot added size: l 
surbhigarg92 force-pushed the snapshot_isolation branch 4 times, most recently from 7f671bb to f6f44b6 Compare 
| @olavloite Can you please do one more round of review. Note: Python does not have a similar method like "mergeFrom" in Java. It would need a custom method to merge protos iteratively. |
parthea added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run surbhigarg92 force-pushed the snapshot_isolation branch 4 times, most recently from 497bf85 to 7538b59 Compare surbhigarg92 force-pushed the snapshot_isolation branch from 7538b59 to e535c00 Compare surbhigarg92 force-pushed the snapshot_isolation branch from e535c00 to a354f4a Compare | @@ -165,6 +167,10 @@ class Client(ClientWithProject): | |||
| or you can use the environment variable `SPANNER_ENABLE_END_TO_END_TRACING=<boolean>` | |||
| to control it. | |||
| | |||
| :type default_transaction_options: :class:`~google.cloud.spanner_v1.DefaultTransactionOptions` | |||
| or :class:`dict` | |||
| :param default_transaction_options: (Optional) Default options to use for all transactions. | |||
There was a problem hiding this comment.
Should we clearly call out that this is only for r/w transactions?
| :param default_transaction_options: (Optional) Default options to use for all transactions. | |
| :param default_transaction_options: (Optional) Default options to use for all read/write transactions. |
There was a problem hiding this comment.
I wanted to keep it flexible for all types of transaction options. For example, if we add exclude_txn_from_change_streams to the default transaction options, it should apply to both RW and PDML. To handle this, we can introduce another private property _defaultPDMTransactionOptions within the DefaultTransactionOptions class, where exclude_txn_from_change_streams will be set.
No description provided.