fix(tracing): only set span.status=OK if UNSET #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: spanner 
harshachinta reviewed Dec 4, 2024
harshachinta reviewed Dec 4, 2024
harshachinta reviewed Dec 4, 2024
harshachinta reviewed Dec 4, 2024
odeke-em force-pushed the trace-fix-trace_call-unconditionally-setting-span_status_OK branch from d1018ac to f1d41ee Compare 
harshachinta added the kokoro:force-run harshachinta approved these changes Dec 4, 2024
harshachinta added the do not merge 
yoshi-kokoro removed the kokoro:force-run 
In modernized OpenTelemetry-Python, if the SpanStatus was not already set to OK, it can be changed and the code for trace_call was accidentally unconditionally setting the status to OK if there was no exception. This change fixes that and adds tests to lock this behavior in. Fixes googleapis#1246
odeke-em force-pushed the trace-fix-trace_call-unconditionally-setting-span_status_OK branch from f1d41ee to 981fab5 Compare harshachinta added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run harshachinta added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run harshachinta added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run harshachinta added kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In modernized OpenTelemetry-Python, if the SpanStatus was not already set to OK, it can be changed and
the code for trace_call was accidentally unconditionally setting the status to OK if there was no exception. This change fixes that and adds tests to lock this behavior in.
Fixes #1246