fix: missing method implementation and potential bug in the DatabaseWrapper class #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…in_usable()` methods of the `DatabaseWrapper` class
google-cla bot added the cla: yes 
mf2199 added api: spanner 
IlyaFaer approved these changes Oct 26, 2020
c24t reviewed Oct 26, 2020
django_spanner/base.py Outdated
Comment on lines 87 to 88
| # These are all no-ops in favor of using REGEXP_CONTAINS | ||
| # in the customized lookups. |
There was a problem hiding this comment.
Suggested change
| # These are all no-ops in favor of using REGEXP_CONTAINS | |
| # in the customized lookups. | |
| # These are all no-ops in favor of using REGEXP_CONTAINS in the customized | |
| # lookups. |
Why rewrap this?
mf2199 commented Nov 15, 2020
c24t reviewed Dec 16, 2020
| | ||
| | ||
| @mock_import() | ||
| @unittest.skipIf(sys.version_info < (3, 6), reason="Skipping Python 3.5") |
There was a problem hiding this comment.
I think we can safely drop 3.5 in tests since we already decided not to support it elsewhere.
c24t force-pushed the django-spanner-base branch from 7f1dd87 to 29652ac Compare c24t approved these changes Dec 17, 2020
| } | ||
| | ||
| Database = Database | ||
| Database = spanner_dbapi |
There was a problem hiding this comment.
FWIW this odd "import x as Database; Database = Database" pattern seems to come from sqlite (https://github.com/django/django/blob/e893c0ad8b0b5b0a1e5be3345c287044868effc4/django/db/backends/sqlite3/base.py#L156), and is copied in all the other built in backends.
This was referenced Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change list:
DatabaseWrapper.init_connection_state()method;DatabaseWrappper.is_usable()condition check;