Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

docs(samples): add checksum snippets #255

Merged
merged 9 commits into from
Mar 13, 2022
Merged

docs(samples): add checksum snippets #255

merged 9 commits into from
Mar 13, 2022

Conversation

@gwhitehawk
Copy link
Contributor

@gwhitehawk gwhitehawk commented Mar 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ x] Ensure the tests and linter pass
  • [x ] Code coverage does not decrease (if any source code was changed)
  • [ x] Appropriate docs were updated (if necessary)

Fixes #254 🦕
@product-auto-label product-auto-label bot added api: secretmanager Issues related to the googleapis/python-secret-manager API. samples Issues that are directly related to samples. labels Mar 1, 2022
parthea
parthea reviewed Mar 5, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one observation, otherwise LGTM
@gcf-owl-bot
docs(samples): add checksum snippets
10b44bd 
Source-Link: googleapis/synthtool@571ee2c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:660abdf857d3ab9aabcd967c163c70e657fcc5653595c709263af5f3fa23ef67
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
parthea
parthea reviewed Mar 12, 2022
View reviewed changes
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 12, 2022
parthea
parthea reviewed Mar 12, 2022
View reviewed changes
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 12, 2022
@parthea parthea merged commit 2095a04 into googleapis:main Mar 13, 2022
@release-please release-please bot mentioned this pull request Mar 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: secretmanager Issues related to the googleapis/python-secret-manager API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.

3 participants

@gwhitehawk @parthea @yoshi-kokoro