fix(deps): require google-api-core >= 2.8.0 (#315)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 459095142 Source-Link: googleapis/googleapis@4f1be99 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae686d9cde4fc3e36d0ac02efb8643b15890c1ed Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9 feat: add audience parameter PiperOrigin-RevId: 456827138 Source-Link: googleapis/googleapis@23f1a15 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4075a8514f676691ec156688a5bbf183aa9893ce Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9

Author: gcf-owl-bot[bot]

google/cloud/secretmanager_v1/services/secret_manager_service/client.py

@@ -472,6 +472,7 @@ def __init__(
  quota_project_id=client_options.quota_project_id,
  client_info=client_info,
  always_use_jwt_access=True,
+ api_audience=client_options.api_audience,
  )
 
  def list_secrets(

google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py

@@ -57,6 +57,7 @@ def __init__(
  quota_project_id: Optional[str] = None,
  client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
  always_use_jwt_access: Optional[bool] = False,
+ api_audience: Optional[str] = None,
  **kwargs,
  ) -> None:
  """Instantiate the transport.
@@ -84,11 +85,6 @@ def __init__(
  be used for service account credentials.
  """
 
- # Save the hostname. Default to port 443 (HTTPS) if none is specified.
- if ":" not in host:
- host += ":443"
- self._host = host
-
  scopes_kwargs = {"scopes": scopes, "default_scopes": self.AUTH_SCOPES}
 
  # Save the scopes.
@@ -109,6 +105,11 @@ def __init__(
  credentials, _ = google.auth.default(
  **scopes_kwargs, quota_project_id=quota_project_id
  )
+ # Don't apply audience if the credentials file passed from user.
+ if hasattr(credentials, "with_gdch_audience"):
+ credentials = credentials.with_gdch_audience(
+ api_audience if api_audience else host
+ )
 
  # If the credentials are service account credentials, then always try to use self signed JWT.
  if (
@@ -121,6 +122,11 @@ def __init__(
  # Save the credentials.
  self._credentials = credentials
 
+ # Save the hostname. Default to port 443 (HTTPS) if none is specified.
+ if ":" not in host:
+ host += ":443"
+ self._host = host
+
  def _prep_wrapped_messages(self, client_info):
  # Precompute the wrapped methods.
  self._wrapped_methods = {

google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py

@@ -66,6 +66,7 @@ def __init__(
  quota_project_id: Optional[str] = None,
  client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
  always_use_jwt_access: Optional[bool] = False,
+ api_audience: Optional[str] = None,
  ) -> None:
  """Instantiate the transport.
 
@@ -161,6 +162,7 @@ def __init__(
  quota_project_id=quota_project_id,
  client_info=client_info,
  always_use_jwt_access=always_use_jwt_access,
+ api_audience=api_audience,
  )
 
  if not self._grpc_channel:

google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc_asyncio.py

@@ -111,6 +111,7 @@ def __init__(
  quota_project_id=None,
  client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
  always_use_jwt_access: Optional[bool] = False,
+ api_audience: Optional[str] = None,
  ) -> None:
  """Instantiate the transport.
 
@@ -206,6 +207,7 @@ def __init__(
  quota_project_id=quota_project_id,
  client_info=client_info,
  always_use_jwt_access=always_use_jwt_access,
+ api_audience=api_audience,
  )
 
  if not self._grpc_channel:

setup.py

@@ -24,10 +24,7 @@
 version = "2.11.1"
 release_status = "Development Status :: 5 - Production/Stable"
 dependencies = [
- # NOTE: Maintainers, please do not require google-api-core>=2.x.x
- # Until this issue is closed
- # https://github.com/googleapis/google-cloud-python/issues/10566
- "google-api-core[grpc] >= 1.31.5, <3.0.0dev,!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.0",
+ "google-api-core[grpc] >= 2.8.0, <3.0.0dev",
  "grpc-google-iam-v1 >= 0.12.4, <1.0.0dev",
  "proto-plus >= 1.15.0, <2.0.0dev",
  "protobuf >= 3.19.0, <4.0.0dev",

testing/constraints-3.6.txt

@@ -5,7 +5,7 @@
 #
 # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
 # Then this file should have foo==1.14.0
-google-api-core==1.31.5
+google-api-core==2.8.0
 grpc-google-iam-v1==0.12.4
 proto-plus==1.15.0
 libcst==0.2.5

testing/constraints-3.7.txt

@@ -239,6 +239,7 @@ def test_secret_manager_service_client_client_options(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # Check the case api_endpoint is not provided and GOOGLE_API_USE_MTLS_ENDPOINT is
@@ -256,6 +257,7 @@ def test_secret_manager_service_client_client_options(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # Check the case api_endpoint is not provided and GOOGLE_API_USE_MTLS_ENDPOINT is
@@ -273,6 +275,7 @@ def test_secret_manager_service_client_client_options(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # Check the case api_endpoint is not provided and GOOGLE_API_USE_MTLS_ENDPOINT has
@@ -302,6 +305,25 @@ def test_secret_manager_service_client_client_options(
  quota_project_id="octopus",
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
+ )
+ # Check the case api_endpoint is provided
+ options = client_options.ClientOptions(
+ api_audience="https://language.googleapis.com"
+ )
+ with mock.patch.object(transport_class, "__init__") as patched:
+ patched.return_value = None
+ client = client_class(client_options=options, transport=transport_name)
+ patched.assert_called_once_with(
+ credentials=None,
+ credentials_file=None,
+ host=client.DEFAULT_ENDPOINT,
+ scopes=None,
+ client_cert_source_for_mtls=None,
+ quota_project_id=None,
+ client_info=transports.base.DEFAULT_CLIENT_INFO,
+ always_use_jwt_access=True,
+ api_audience="https://language.googleapis.com",
  )
 
 
@@ -379,6 +401,7 @@ def test_secret_manager_service_client_mtls_env_auto(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # Check the case ADC client cert is provided. Whether client cert is used depends on
@@ -413,6 +436,7 @@ def test_secret_manager_service_client_mtls_env_auto(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # Check the case client_cert_source and ADC client cert are not provided.
@@ -435,6 +459,7 @@ def test_secret_manager_service_client_mtls_env_auto(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
 
@@ -553,6 +578,7 @@ def test_secret_manager_service_client_client_options_scopes(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
 
@@ -591,6 +617,7 @@ def test_secret_manager_service_client_client_options_credentials_file(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
 
@@ -611,6 +638,7 @@ def test_secret_manager_service_client_client_options_from_dict():
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
 
@@ -649,6 +677,7 @@ def test_secret_manager_service_client_create_channel_credentials_file(
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )
 
  # test that the credentials from file are saved and used as the credentials.
@@ -4797,6 +4826,28 @@ def test_secret_manager_service_transport_auth_adc(transport_class):
  )
 
 
+@pytest.mark.parametrize(
+ "transport_class",
+ [
+ transports.SecretManagerServiceGrpcTransport,
+ transports.SecretManagerServiceGrpcAsyncIOTransport,
+ ],
+)
+def test_secret_manager_service_transport_auth_gdch_credentials(transport_class):
+ host = "https://language.com"
+ api_audience_tests = [None, "https://language2.com"]
+ api_audience_expect = [host, "https://language2.com"]
+ for t, e in zip(api_audience_tests, api_audience_expect):
+ with mock.patch.object(google.auth, "default", autospec=True) as adc:
+ gdch_mock = mock.MagicMock()
+ type(gdch_mock).with_gdch_audience = mock.PropertyMock(
+ return_value=gdch_mock
+ )
+ adc.return_value = (gdch_mock, None)
+ transport_class(host=host, api_audience=t)
+ gdch_mock.with_gdch_audience.assert_called_once_with(e)
+
+
 @pytest.mark.parametrize(
  "transport_class,grpc_helpers",
  [
@@ -5318,4 +5369,5 @@ def test_api_key_credentials(client_class, transport_class):
  quota_project_id=None,
  client_info=transports.base.DEFAULT_CLIENT_INFO,
  always_use_jwt_access=True,
+ api_audience=None,
  )