Skip to content

fix: drop python 3.7 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix: drop python 3.7 #402

merged 1 commit into from
Feb 15, 2023

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Feb 15, 2023

test: drop dependency on asynctest

Towards #401
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsublite Issues related to the googleapis/python-pubsublite API. labels Feb 15, 2023
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2023
@parthea
Copy link
Contributor Author

parthea commented Feb 15, 2023

#400 should be merged before we drop python 3.7
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@parthea parthea mentioned this pull request Feb 15, 2023
Merged
parthea
parthea commented Feb 15, 2023
View reviewed changes
CONTRIBUTING.rst

We also explicitly decided to support Python 3 beginning with version 3.7.
We also explicitly decided to support Python 3 beginning with version 3.8.
Reasons for this include:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened googleapis/synthtool#1766 to remove this section from CONTRIBUTING.rst as it is obsolete.
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2023
@parthea parthea marked this pull request as ready for review February 15, 2023 16:06
@parthea parthea requested review from a team as code owners February 15, 2023 16:06
@parthea parthea merged commit 261b48d into main Feb 15, 2023
@parthea parthea deleted the drop-py37 branch February 15, 2023 16:07
@release-please release-please bot mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. size: m Pull request size is medium.

3 participants

@parthea @dpcollins-google