Skip to content

fix: Mark test_streaming_pull_max_messages flaky #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukund-ananthu merged 1 commit into from
Nov 2, 2024
Merged

fix: Mark test_streaming_pull_max_messages flaky #1288

mukund-ananthu merged 1 commit into from
Nov 2, 2024

Conversation

@mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Nov 1, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1160 🦕
@mukund-ananthu mukund-ananthu requested review from a team as code owners November 1, 2024 21:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Nov 1, 2024
@mukund-ananthu mukund-ananthu self-assigned this Nov 2, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2024
@mukund-ananthu mukund-ananthu merged commit d6635a0 into main Nov 2, 2024
17 checks passed
@mukund-ananthu mukund-ananthu deleted the sysFlaky branch November 2, 2024 17:32
@release-please release-please bot mentioned this pull request Nov 2, 2024
Merged
@mukund-ananthu mukund-ananthu mentioned this pull request Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

2 participants

@mukund-ananthu @hongalex