test: Fix test failures due to grpcio changes #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
mukund-ananthu force-pushed the fixK branch 4 times, most recently from 272e34e to b959dd1 Compare product-auto-label bot added size: m mukund-ananthu force-pushed the fixK branch 4 times, most recently from 608092f to 2dc559c Compare mukund-ananthu added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run mukund-ananthu force-pushed the fixK branch 3 times, most recently from ee9c76a to 1e4efdc Compare * Failures can be found in googleapis/python-api-common-protos#223
parthea changed the title parthea changed the title 
parthea approved these changes May 30, 2024
Comment on lines +136 to +141
| # Behavior to include dns prefix changed in gRPCv1.63 | ||
| grpc_major, grpc_minor = [int(part) for part in grpc.__version__.split(".")[0:2]] | ||
| if grpc_major > 1 or (grpc_major == 1 and grpc_minor >= 63): | ||
| _EXPECTED_TARGET = "dns:///testendpoint.google.com:443" | ||
| else: | ||
| _EXPECTED_TARGET = "testendpoint.google.com:443" |
Contributor
There was a problem hiding this comment.
This could be moved to a help function to avoid duplication. I'll go ahead and approve since the builds are failing at main but consider creating a follow up PR to reduce code duplication.
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1177 🦕