Skip to content

Commit 8f75047

Browse files
committed
address PR feedback
1 parent 7099d5e commit 8f75047

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

google/cloud/pubsub_v1/publisher/client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ def __init__(
128128
# Sanity check: Is our goal to use the emulator?
129129
# If so, create a grpc insecure channel with the emulator host
130130
# as the target.
131+
# TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
132+
# code below to test files.
131133
if os.environ.get("PUBSUB_EMULATOR_HOST"):
132134
kwargs["client_options"] = {
133135
"api_endpoint": os.environ.get("PUBSUB_EMULATOR_HOST")

google/pubsub_v1/services/publisher/client.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -712,9 +712,7 @@ def __init__(
712712
else cast(Callable[..., PublisherTransport], transport)
713713
)
714714
# initialize with the provided callable or the passed in class
715-
716-
# TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
717-
# code below to test files.
715+
718716
emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
719717
if emulator_host:
720718
if issubclass(transport_init, type(self)._transport_registry["grpc"]):

google/pubsub_v1/services/subscriber/client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -717,8 +717,6 @@ def __init__(
717717
)
718718
# initialize with the provided callable or the passed in class
719719

720-
# TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
721-
# code below to test files.
722720
emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
723721
if emulator_host:
724722
if issubclass(transport_init, type(self)._transport_registry["grpc"]):

owlbot.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@
103103
clients_to_patch,
104104
r"# initialize with the provided callable or the passed in class",
105105
"""\g<0>
106-
106+
# TODO(https://github.com/googleapis/python-pubsub/issues/1349): Move the emulator
107+
# code below to test files.
107108
emulator_host = os.environ.get("PUBSUB_EMULATOR_HOST")
108109
if emulator_host:
109110
if issubclass(transport_init, type(self)._transport_registry["grpc"]):

0 commit comments

Comments
 (0)