fix: preserve list meanings #575
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the library only keeps track of the
meaning
field of sub-elements of array_values it sees. We also need it to keep track of themeaning
of the array itselfThis PR addresses this by returning a tuple of
(root_meaning, sub_meaning_list)
instead of just the sub_meaning_list in_get_meaning()
, and using the tuple to populate the fields properly in_set_pb_meaning_from_entity()