Skip to content

fix: Fix system test using utc timezone #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2023
Merged

fix: Fix system test using utc timezone #406

merged 3 commits into from
Jan 23, 2023

Conversation

Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Jan 18, 2023 •
edited
Loading

Specify the utc timezone when using datetime.now() in snapshot reads test cases.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@Mariatta
fix: Fix system test using utc timezone
2a9f638 
Specify the utc timezone when using datetime.now() in snapshot reads test cases.
@Mariatta Mariatta requested review from a team as code owners January 18, 2023 22:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/python-datastore API. labels Jan 18, 2023
@Mariatta Mariatta added the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 93537ef into main Jan 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-system-test branch January 23, 2023 16:38
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2023
@release-please release-please bot mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-datastore API. size: xs Pull request size is extra small.
2 participants
@Mariatta @m-strzelczyk