Skip to content

feat: add total slot ms to RowIterator #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

feat: add total slot ms to RowIterator #2233

merged 4 commits into from
Jul 11, 2025

Conversation

Genesis929
Copy link
Contributor

@Genesis929 Genesis929 commented Jul 9, 2025 •
edited
Loading

We need this for BigFrames, see #2234
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2234
@Genesis929 Genesis929 requested review from a team as code owners July 9, 2025 23:37
@Genesis929 Genesis929 requested a review from suzmue July 9, 2025 23:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 9, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 9, 2025
@Genesis929 Genesis929 marked this pull request as draft July 9, 2025 23:37
@chalmerlowe chalmerlowe requested review from chalmerlowe and removed request for suzmue July 10, 2025 15:23
chalmerlowe
chalmerlowe requested changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Genesis929

Github indicated that my review was requested, however...

it might just be a bit over eager...

  • the PR is still marked as draft
  • there is no description outlining why this change is being suggested

As soon as this PR has a description and moves out of Draft status, please let me know and I will gladly take a second look.

So far, everything I see seems good.
@Genesis929
Copy link
Contributor Author

@Genesis929

Github indicated that my review was requested, however...

it might just be a bit over eager...

  • the PR is still marked as draft
  • there is no description outlining why this change is being suggested

As soon as this PR has a description and moves out of Draft status, please let me know and I will gladly take a second look.

So far, everything I see seems good.

Thank you very much! Sorry for the trouble, I was going to create a draft, but I accidentally created a pull request, and have to change it back to draft.
@Genesis929 Genesis929 marked this pull request as ready for review July 10, 2025 17:25
@Genesis929 Genesis929 requested a review from chalmerlowe July 10, 2025 17:26
chalmerlowe
chalmerlowe approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@chelsea-lin chelsea-lin merged commit d44bf02 into googleapis:main Jul 11, 2025
24 checks passed
@release-please release-please bot mentioned this pull request Jul 11, 2025
Merged
This was referenced Jul 22, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

5 participants

@Genesis929 @chalmerlowe @shollyman @agrawal-siddharth @chelsea-lin