feat: support using BIGQUERY_EMULATOR_HOST environment variable #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…lsalas/python-bigquery into apb_feature_bq_emulator
…lsalas/python-bigquery into apb_feature_bq_emulator
product-auto-label bot added size: s 
steffnay suggested changes Apr 19, 2022
Contributor
steffnay left a comment
steffnay left a comment There was a problem hiding this comment.
Looking good! Just needing changes to variable naming and then the additional tests you have planned.
product-auto-label bot added size: m steffnay reviewed Apr 25, 2022
…lsalas/python-bigquery into apb_feature_bq_emulator
product-auto-label bot added size: s 
steffnay changed the title steffnay approved these changes Apr 28, 2022
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
…leapis#1222) * feat:adding emulator * apb_feature_bq_emulator_test * apb_feature_bq_emulator_variable_name_change * abecerrilsalas_feature_bq_emulator_typo_changes * feat:fixing var names and start of test * abecerrilsalas_feature_additional_tests * feat: testing update * feat: fixed failed lint test
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…leapis#1222) * feat:adding emulator * apb_feature_bq_emulator_test * apb_feature_bq_emulator_variable_name_change * abecerrilsalas_feature_bq_emulator_typo_changes * feat:fixing var names and start of test * abecerrilsalas_feature_additional_tests * feat: testing update * feat: fixed failed lint test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
Implemented a BIGQUERY_EMULATOR_HOST environment variable to be used to set the api_endpoint in the python-bigquery client constructor.
Why?
Users have requested this implementation (#1193). Currently there is no logic to check for the existence of a BIGQUERY_EMULATOR_HOST or some similar environment variable
How?
Logic was applied and code was changed in the _helpers.py and client.py files.
Fixes #1193 🦕