fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
busunkim96 requested review from a team, parthea and tswast and removed request for a team 
product-auto-label bot added the api: bigquery busunkim96 changed the title 
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
parthea changed the title …ddress (#942) * chore: update system tests and samples to use and @google.com email address * Add group prefix * fixed access entry some more
nicain approved these changes Mar 14, 2022
tswast approved these changes Mar 25, 2022
Contributor
tswast left a comment
tswast left a comment There was a problem hiding this comment.
LGTM. Test failures look like a conflict between new pandas and old pyarrow, but probably not worth investigating further.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allow google-api-core<3.0.0dev on previous release of library. This will be followed by a release PR.