Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Feb 17, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #209 🦕

@tswast tswast requested a review from a team as a code owner February 17, 2022 20:07
@tswast tswast requested review from a team and shollyman February 17, 2022 20:07
@product-auto-label product-auto-label bot added the api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API. label Feb 17, 2022
Copy link

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 6eea2a3 into main Feb 18, 2022
@tswast tswast deleted the tswast-patch-1 branch February 18, 2022 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API.

3 participants