Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Conversation

@ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Nov 10, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #109 🦕

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg requested a review from a team as a code owner November 10, 2022 19:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 10, 2022
@Mariatta
Copy link
Contributor

Can we do Python 3.11 too?

@ziegenberg
Copy link
Contributor Author

Can we do Python 3.11 too?

Sure. I would put it into a separate PR

@ziegenberg
Copy link
Contributor Author

@Mariatta could you give the CI a little push to start the testing? Would be awesome :)

@ziegenberg ziegenberg mentioned this pull request Nov 10, 2022
4 tasks
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@parthea parthea merged commit 63ca888 into googleapis:main Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

4 participants