Skip to content

docs(samples): add samples to create/delete featurestore #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 24, 2022
Merged

docs(samples): add samples to create/delete featurestore #980

merged 13 commits into from
Feb 24, 2022

Conversation

nayaknishant
Copy link
Contributor

Migrating GAPIC feature store samples to SDK. Completed 2/8 samples with units tests, would appreciate feedback.
@nayaknishant nayaknishant requested review from a team as code owners January 27, 2022 00:42
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 27, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@parthea parthea changed the title feat: SDK feature store samples (create/delete fs) docs(samples): add samples to create/delete featurestore Jan 27, 2022
morgandu
morgandu suggested changes Feb 1, 2022
View reviewed changes
morgandu
morgandu suggested changes Feb 24, 2022
View reviewed changes
@morgandu morgandu self-requested a review February 24, 2022 21:14
@morgandu
Copy link
Contributor

LGTM! Thanks!
@nayaknishant nayaknishant merged commit 5ee6354 into googleapis:main Feb 24, 2022
@release-please release-please bot mentioned this pull request Feb 24, 2022
Merged
nayaknishant added a commit to nayaknishant/python-aiplatform that referenced this pull request Feb 24, 2022
@nayaknishant @morgandu
docs(samples): add samples to create/delete featurestore (googleapis#980
b19fbf0 
) * feat: SDK feature store samples (create/delete fs) * feat: adding to conftest.py * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples) added changes * docs(samples): style issues * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> Co-authored-by: Morgan Du <morgandu@google.com>
nayaknishant added a commit that referenced this pull request Feb 25, 2022
@nayaknishant @morgandu
docs(samples): added create feature and create entity type samples an…
d221e6b 
…d tests (#984) * feat: SDK feature store samples (create/delete fs) * feat: adding to conftest.py * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples) added changes * docs(samples): style issues * adding create entity * docs(samples): added create feature and entity type * docs(samples): edited test * docs(samples) edited style * moving constants * fixed dates * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * docs(samples): add samples to create/delete featurestore (#980) * feat: SDK feature store samples (create/delete fs) * feat: adding to conftest.py * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples) added changes * docs(samples): style issues * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * moving constants * added variables, made fixes, fixed spelling Co-authored-by: Morgan Du <morgandu@google.com>
nayaknishant added a commit that referenced this pull request Mar 8, 2022
@nayaknishant @morgandu
docs(samples): read, import, batch_serve, batch_create features (#1046)
80dd40d 
* feat: SDK feature store samples (create/delete fs) * feat: adding to conftest.py * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples) added changes * docs(samples): style issues * adding create entity * docs(samples): added create feature and entity type * docs(samples): edited test * docs(samples) edited style * moving constants * fixed dates * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * docs(samples): add samples to create/delete featurestore (#980) * feat: SDK feature store samples (create/delete fs) * feat: adding to conftest.py * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples): fixed testing * docs(samples) added changes * docs(samples): style issues * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/create_featurestore_sample_test.py Co-authored-by: Morgan Du <morgandu@google.com> Co-authored-by: Morgan Du <morgandu@google.com> * Update samples/model-builder/test_constants.py Co-authored-by: Morgan Du <morgandu@google.com> * moving constants * added variables, made fixes, fixed spelling * batch_create_features_sample and test * added batch serve to bq and test * working on batch samples * fixed batch_serve_to_bq test * added read sample * moving constants * added featurestore samples * lint issues * adding revisions * adding revisions, fixing tests * editing spacing for readability Co-authored-by: Morgan Du <morgandu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

2 participants

@nayaknishant @morgandu