Skip to content

Conversation

samgoodman
Copy link
Contributor

@samgoodman samgoodman commented Jun 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Sam Goodman and others added 30 commits April 11, 2022 22:26
Sam Goodman and others added 17 commits June 28, 2022 21:15
@samgoodman samgoodman merged commit d890685 into main Jun 29, 2022
@samgoodman samgoodman deleted the goodmansam/versioningfull branch June 29, 2022 01:20
sararob pushed a commit to sararob/python-aiplatform that referenced this pull request Jun 29, 2022
* Initial changes for first ModelRegistry design proposal * More changes for design doc * ModelRegistry class implementation * Added method docs * Changes from book doc * training_jobs versioning changes * More models.py changes for versioning * More version arg plumbing * Tests, implementation changes, and assorted tweaks to make GAPIC stuff work * Batch predict versioning, variable name cleanup * Reset training_jobs changes to limit scope * Prediction test fixes * Blackend and lint changes * Training jobs versioning support * Blackend and lint changes * Added TODO for async support * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Override for _construct_sdk_resource_from_gapic * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Fixed _construct_sdk_resource_from_gapic for Model class and gave documentation * Removed errant futuremanager init * Start of new versioning system test * Pass model version on upload cls init * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Fully-fleshed system test for model versioning * Improvements based on system testing * Nox fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Nox fixes * Initial commit for vertexpreviews, with compat changes * Use compat type for DeploymentResourcesType * PR Feedback * Test compat fixes * More v1->v1beta1 shifts * Plumbing model changes through more tests * chore: release 1.13.1 Release-As: 1.13.1 * Nox run * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Training jobs test fixes * Reverted v1beta1 changes * Blacken and lint changes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * PR feedback changes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revert "🦉 Updates from OwlBot post-processor" This reverts commit 0bff90b. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revert "🦉 Updates from OwlBot post-processor" This reverts commit c57f305. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revert "🦉 Updates from OwlBot post-processor" This reverts commit ee5ff17. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Prevent owlbot from re-adding 3.6 dependencies * Test fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * nox blacken * Test fixes for 3.6 compat * Test fix for 3.6 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Quitting the fight against nox * Test fixes for python 3.7 * System test cleanup * retrigger checks * Update google/cloud/aiplatform/models.py Missing '.' Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * Update google/cloud/aiplatform/models.py Another missing '.' Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * Update google/cloud/aiplatform/models.py Missing return type Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * Update google/cloud/aiplatform/models.py Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * PR feedback changes * Pass location, project, creds to Model Registry * Credential fix when getting model from registry * Copyright update * Fixed issue with Model update trying to update a version, rather than the base model * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revert "fix: Prevent owlbot from re-adding 3.6 dependencies" This reverts commit 4322fe2. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Nox blacken * Revert "🦉 Updates from OwlBot post-processor" This reverts commit fe5a27b. * Fighting with owlbot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Sam Goodman <goodmansam@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xl Pull request size is extra large.

3 participants