Skip to content

Commit 3224ae3

Browse files
authored
feat: allow creating featurestore without online node (#1180)
1 parent c871e73 commit 3224ae3

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

google/cloud/aiplatform/featurestore/featurestore.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ def create(
447447
The value must be unique within the project and location.
448448
online_store_fixed_node_count (int):
449449
Optional. Config for online serving resources.
450-
When not specified, default node count is 1. The
450+
When not specified, no fixed node count for online serving. The
451451
number of nodes will not scale automatically but
452452
can be scaled manually by providing different
453453
values when updating.
@@ -496,7 +496,7 @@ def create(
496496
"""
497497
gapic_featurestore = gca_featurestore.Featurestore(
498498
online_serving_config=gca_featurestore.Featurestore.OnlineServingConfig(
499-
fixed_node_count=online_store_fixed_node_count or 1
499+
fixed_node_count=online_store_fixed_node_count
500500
)
501501
)
502502

tests/system/aiplatform/test_featurestore.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ def test_create_get_list_featurestore(self, shared_state):
6565
featurestore_id = self._make_display_name(key=_TEST_FEATURESTORE_ID).replace(
6666
"-", "_"
6767
)[:60]
68-
featurestore = aiplatform.Featurestore.create(featurestore_id=featurestore_id)
68+
featurestore = aiplatform.Featurestore.create(
69+
featurestore_id=featurestore_id, online_store_fixed_node_count=1
70+
)
6971

7072
shared_state["resources"] = [featurestore]
7173
shared_state["featurestore"] = featurestore

0 commit comments

Comments
 (0)