Skip to content

Commit 079b1f9

Browse files
jsondaicopybara-github
authored andcommitted
fix: GenAI SDK client - Fix JS variable name conflict in evals visualization for VS Code iPython environment
PiperOrigin-RevId: 785527326
1 parent 943c1e4 commit 079b1f9

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

vertexai/_genai/_evals_visualization.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def _get_evaluation_html(eval_result_json: str) -> str:
101101
<div id="details-section"></div>
102102
</div>
103103
<script>
104-
const data = {eval_result_json};
104+
const vizData = {eval_result_json};
105105
function renderSummary(summaryMetrics) {{
106106
const container = document.getElementById('summary-section');
107107
let content = '<h2>Summary Metrics</h2>';
@@ -150,8 +150,8 @@ def _get_evaluation_html(eval_result_json: str) -> str:
150150
container.innerHTML += card + '</details>';
151151
}});
152152
}}
153-
renderSummary(data.summary_metrics);
154-
renderDetails(data.eval_case_results, data.metadata);
153+
renderSummary(vizData.summary_metrics);
154+
renderDetails(vizData.eval_case_results, vizData.metadata);
155155
</script>
156156
</body>
157157
</html>
@@ -196,7 +196,7 @@ def _get_comparison_html(eval_result_json: str) -> str:
196196
<div id="details-section"></div>
197197
</div>
198198
<script>
199-
const data = {eval_result_json};
199+
const vizData = {eval_result_json};
200200
function renderSummary(summaryMetrics, metadata) {{
201201
const container = document.getElementById('summary-section');
202202
if (!summaryMetrics || summaryMetrics.length === 0) {{ container.innerHTML = '<h2>Summary Metrics</h2><p>No summary metrics.</p>'; return; }}
@@ -252,8 +252,8 @@ def _get_comparison_html(eval_result_json: str) -> str:
252252
container.innerHTML += card + '</div></details>';
253253
}});
254254
}}
255-
renderSummary(data.summary_metrics, data.metadata);
256-
renderDetails(data.eval_case_results, data.metadata);
255+
renderSummary(vizData.summary_metrics, vizData.metadata);
256+
renderDetails(vizData.eval_case_results, vizData.metadata);
257257
</script>
258258
</body>
259259
</html>
@@ -289,7 +289,7 @@ def _get_inference_html(dataframe_json: str) -> str:
289289
<div id="results-table"></div>
290290
</div>
291291
<script>
292-
const data = {dataframe_json};
292+
const vizData = {dataframe_json};
293293
const container = document.getElementById('results-table');
294294
295295
function renderCell(cellValue) {{
@@ -306,13 +306,13 @@ def _get_inference_html(dataframe_json: str) -> str:
306306
return `<td>${{cellContent}}</td>`;
307307
}}
308308
309-
if (!data || data.length === 0) {{ container.innerHTML = "<p>No data.</p>"; }}
309+
if (!vizData || vizData.length === 0) {{ container.innerHTML = "<p>No data.</p>"; }}
310310
else {{
311311
let table = '<table><thead><tr>';
312-
const headers = Object.keys(data[0] || {{}});
312+
const headers = Object.keys(vizData[0] || {{}});
313313
headers.forEach(h => table += `<th>${{h}}</th>`);
314314
table += '</tr></thead><tbody>';
315-
data.forEach(row => {{
315+
vizData.forEach(row => {{
316316
table += '<tr>';
317317
headers.forEach(header => {{
318318
table += renderCell(row[header]);

0 commit comments

Comments
 (0)