- Notifications
You must be signed in to change notification settings - Fork 2
fix: Remove deprecated v1beta1 API that is no longer available #154
Conversation
Here is the summary of changes. You are about to delete 8 region tags.
This comment is generated by snippet-bot.
|
Owl bot is regenerating pull request 154... |
c068194
to b892bc8
Compare The only change I see is |
The intention of the original change is to remove v1beta1 API. I'm going to delete that directory. |
After looking at the code, I just realized we can not simply remove that directory. |
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md fix!: Remove deprecated v1beta1 API that is no longer available BREAKING CHANGE: PiperOrigin-RevId: 426957789 Source-Link: googleapis/googleapis@42d9ed3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2e0f3f1e3837f82d4bb1bf1269b307dc68802bdc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmUwZjNmMWUzODM3ZjgyZDRiYjFiZjEyNjliMzA3ZGM2ODgwMmJkYyJ9
71f1778
to 8b7fd32
Compare Owlbot is failing with
|
8b7fd32
to 6042b83
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing ✅ until we figure out surface difference bween v1beta1 and v1.
This is going to be a major bump. We also have a plan to stop supporting node 10 on Mar 31 which would be another major bump, so we're considering combining these two major bumps. I added |
Since we also needed to change the default version and the old default version already doesn't exist, we decided to release this without major bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
fix!: Remove deprecated v1beta1 API that is no longer available BREAKING CHANGE:
PiperOrigin-RevId: 426957789
Source-Link: googleapis/googleapis@42d9ed3
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2e0f3f1e3837f82d4bb1bf1269b307dc68802bdc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmUwZjNmMWUzODM3ZjgyZDRiYjFiZjEyNjliMzA3ZGM2ODgwMmJkYyJ9