Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 7, 2022

  • Regenerate this pull request now.

🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix!: Remove deprecated v1beta1 API that is no longer available BREAKING CHANGE:

PiperOrigin-RevId: 426957789

Source-Link: googleapis/googleapis@42d9ed3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2e0f3f1e3837f82d4bb1bf1269b307dc68802bdc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmUwZjNmMWUzODM3ZjgyZDRiYjFiZjEyNjliMzA3ZGM2ODgwMmJkYyJ9

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 7, 2022 19:52
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 7, 2022
@product-auto-label product-auto-label bot added the api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. label Feb 7, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 7, 2022

Here is the summary of changes.

You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Feb 7, 2022

Owl bot is regenerating pull request 154...
Build name: ZjRmMDBiMjQtODg4Mi00NjMwLWJjM2ItNTA0YTJmNTU2N2Q5

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-d5df0e0c-6493-4a91-bb55-7651e80aa288 branch from c068194 to b892bc8 Compare February 7, 2022 22:38
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

The only change I see is linkinator.config.json which doesn't match with the PR title.

@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

The intention of the original change is to remove v1beta1 API. I'm going to delete that directory.

@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

After looking at the code, I just realized we can not simply remove that directory.

@tmatsuo tmatsuo changed the title fix!: Remove deprecated v1beta1 API that is no longer available BREAKING CHANGE: fix: Remove deprecated v1beta1 API that is no longer available Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
gcf-owl-bot bot and others added 3 commits February 8, 2022 10:41
@tmatsuo tmatsuo force-pushed the owl-bot-d5df0e0c-6493-4a91-bb55-7651e80aa288 branch from 71f1778 to 8b7fd32 Compare February 8, 2022 18:41
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

Owlbot is failing with

2022-02-08 18:42:46,754 synthtool [INFO] > Collected versions $['v1', 'v1beta1'] from $src INFO:synthtool:Collected versions $['v1', 'v1beta1'] from $src ... ... FileNotFoundError: [Errno 2] No such file or directory: 'src/v1beta1/index.ts' 
@tmatsuo tmatsuo force-pushed the owl-bot-d5df0e0c-6493-4a91-bb55-7651e80aa288 branch from 8b7fd32 to 6042b83 Compare February 8, 2022 18:52
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing ✅ until we figure out surface difference bween v1beta1 and v1.

@tmatsuo tmatsuo changed the title fix: Remove deprecated v1beta1 API that is no longer available fix!: Remove deprecated v1beta1 API that is no longer available Feb 8, 2022
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 8, 2022
@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

This is going to be a major bump. We also have a plan to stop supporting node 10 on Mar 31 which would be another major bump, so we're considering combining these two major bumps. I added Do Not Merge label.

@bcoe bcoe self-requested a review February 8, 2022 19:17
@tmatsuo tmatsuo changed the title fix!: Remove deprecated v1beta1 API that is no longer available fix: Remove deprecated v1beta1 API that is no longer available Feb 8, 2022
@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 8, 2022

Since we also needed to change the default version and the old default version already doesn't exist, we decided to release this without major bump.

@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 8, 2022
Copy link
Contributor

@irataxy irataxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tmatsuo tmatsuo merged commit 76d9aab into main Feb 8, 2022
@tmatsuo tmatsuo deleted the owl-bot-d5df0e0c-6493-4a91-bb55-7651e80aa288 branch February 8, 2022 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. owl-bot-copy
4 participants