chore: callback method in getDatabaseDialect #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
alkatrivedi added kokoro:force-run 
gcf-owl-bot bot removed the owlbot:run 
odeke-em reviewed Jul 9, 2024
yoshi-kokoro removed the kokoro:force-run alkatrivedi added kokoro:force-run gcf-owl-bot bot removed the owlbot:run odeke-em approved these changes Jul 10, 2024
| Thanks for approving the PR @odeke-em |
| @alkatrivedi Please add a unit test case . |
yoshi-kokoro removed the kokoro:force-run 
alkatrivedi force-pushed the callback-get-database-dialect branch from 86decda to 547c0bb Compare alkatrivedi added kokoro:force-run gcf-owl-bot bot removed the owlbot:run
A unit test already exists for this |
surbhigarg92 approved these changes Jul 19, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 19, 2024
🤖 I have created a release *beep* *boop* --- ## [7.10.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.9.1...v7.10.0) (2024-07-19) ### Features * Add field lock_hint in spanner.proto ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b)) * Add field order_by in spanner.proto ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b)) * Add QueryCancellationAction message in executor protos ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b)) * Add support for change streams transaction exclusion option for Batch Write ([#2070](https://togithub.com/googleapis/nodejs-spanner/issues/2070)) ([2a9e443](https://togithub.com/googleapis/nodejs-spanner/commit/2a9e44328acda310db2d0d65d32ad82d77a9fcb0)) * **spanner:** Add support for Cloud Spanner Scheduled Backups ([#2045](https://togithub.com/googleapis/nodejs-spanner/issues/2045)) ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b)) * Update Nodejs generator to send API versions in headers for GAPICs ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b)) ### Bug Fixes * Callback in getDatabaseDialect ([#2078](https://togithub.com/googleapis/nodejs-spanner/issues/2078)) ([7e4a8e9](https://togithub.com/googleapis/nodejs-spanner/commit/7e4a8e9ad4f785b15b68aaa06b6480098d7995ba)) * **deps:** Update dependency google-gax to v4.3.8 ([#2077](https://togithub.com/googleapis/nodejs-spanner/issues/2077)) ([e927880](https://togithub.com/googleapis/nodejs-spanner/commit/e927880ff786a2528a2bbb063a244af3c42ff69c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes: #2075