Skip to content

fix: cleanup different types of session pools #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
surbhigarg92 merged 9 commits into from
Nov 23, 2022
Merged

fix: cleanup different types of session pools #1739

surbhigarg92 merged 9 commits into from
Nov 23, 2022

Conversation

@ko3a4ok
Copy link
Contributor

@ko3a4ok ko3a4ok commented Nov 8, 2022

No description provided.

@ko3a4ok ko3a4ok requested review from a team as code owners November 8, 2022 22:20
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Nov 8, 2022
olavloite
olavloite reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the biggest question here is how we want to handle this change, as it would currently be a breaking change. Do we:

  1. Deprecate fields / interfaces / events that we are no longer using instead of removing them?
  2. Mark this as a breaking change, do a major version bump and set up an LTS branch for the current version?
surbhigarg92
surbhigarg92 reviewed Nov 17, 2022
View reviewed changes
asthamohta
asthamohta reviewed Nov 17, 2022
View reviewed changes
surbhigarg92
surbhigarg92 reviewed Nov 18, 2022
View reviewed changes
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
surbhigarg92
surbhigarg92 reviewed Nov 18, 2022
View reviewed changes
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
@asthamohta asthamohta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 22, 2022
olavloite
olavloite approved these changes Nov 22, 2022
View reviewed changes
@surbhigarg92 surbhigarg92 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 23, 2022
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@surbhigarg92 surbhigarg92 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 23, 2022
@surbhigarg92 surbhigarg92 merged commit 6f55187 into googleapis:main Nov 23, 2022
@release-please release-please bot mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.

5 participants

@ko3a4ok @olavloite @surbhigarg92 @asthamohta @yoshi-kokoro