fix: not check index exclusion path for null values #1330
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1327 🦕
Summary
Considering the following 4 types of index exclusions:
excludeFromindexes: ['foo.*']excludeFromindexes: ['foo.bar']excludeFromindexes: ['foo[].*']excludeFromindexes: ['foo[].bar']Supplying
{ entity: { foo: null } }throws for 2 and 3, but not for 1 and 4.With the changes in this PR, the save calls will not throw in any of the 4 cases.