fix: make ANN algorithm updates based off usage + testing #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change is carved out of PR googleapis#138, due to the fact that at present, Google Cloud Spanner vector index creation and deletion takes a very long time and is non-deterministic hence unreliable for integration tests so these updates which have unit tests are exclusive of the integration tests and allow for usage directly as Google engineering figures out the backend issues. Updates googleapis#94.
product-auto-label bot added the api: spanner 
| /gcbrun |
gauravpurohit06 approved these changes Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change is carved out of PR #138, due to the fact that at present, Google Cloud Spanner vector index creation and deletion takes a very long time and is non-deterministic hence unreliable for integration tests so these updates which have unit tests are exclusive of the integration tests and allow for usage directly as Google engineering figures out the backend issues.
Updates #94.