Skip to content

Commit ba02bf5

Browse files
feat: remove support for Python 3.8 (#97)
* feat: remove support for Python 3.8 * chore: Update sync-repo-settings.yaml --------- Co-authored-by: Averi Kitsch <akitsch@google.com>
1 parent 16fd226 commit ba02bf5

File tree

6 files changed

+17
-13
lines changed

6 files changed

+17
-13
lines changed

.github/sync-repo-settings.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ branchProtectionRules:
2727
requiredStatusCheckContexts:
2828
- "cla/google"
2929
- "lint"
30-
- "mysql-integration-test-pr-py38 (langchain-cloud-sql-testing)"
3130
- "mysql-integration-test-pr-py39 (langchain-cloud-sql-testing)"
3231
- "mysql-integration-test-pr-py310 (langchain-cloud-sql-testing)"
3332
- "mysql-integration-test-pr-py311 (langchain-cloud-sql-testing)"

DEVELOPER.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ These tests are registered as required tests in `.github/sync-repo-settings.yaml
3434

3535
#### Trigger Setup
3636

37-
Cloud Build triggers (for Python versions 3.8 to 3.11) were created with the following specs:
37+
Cloud Build triggers (for Python versions 3.9 to 3.11) were created with the following specs:
3838

3939
```YAML
40-
name: mysql-integration-test-pr-py38
41-
description: Run integration tests on PR for Python 3.8
40+
name: mysql-integration-test-pr-py39
41+
description: Run integration tests on PR for Python 3.9
4242
filename: integration.cloudbuild.yaml
4343
github:
4444
name: langchain-google-cloud-sql-mysql-python
@@ -55,7 +55,7 @@ substitutions:
5555
_INSTANCE_ID: <ADD_VALUE>
5656
_DB_NAME: <ADD_VALUE>
5757
_REGION: us-central1
58-
_VERSION: "3.8"
58+
_VERSION: "3.9"
5959
```
6060

6161
Use `gcloud builds triggers import --source=trigger.yaml` to create triggers via the command line

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ With `virtualenv`_, it’s possible to install this library without needing syst
4444
Supported Python Versions
4545
^^^^^^^^^^^^^^^^^^^^^^^^^
4646

47-
Python >= 3.8
47+
Python >= 3.9
4848

4949
Mac/Linux
5050
^^^^^^^^^

integration.cloudbuild.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,14 @@ steps:
2626
- id: Run integration tests
2727
name: python:${_VERSION}
2828
entrypoint: python
29-
args: ["-m", "pytest", "--cov=langchain_google_cloud_sql_mysql", "--cov-config=.coveragerc", "tests/"]
29+
args:
30+
[
31+
"-m",
32+
"pytest",
33+
"--cov=langchain_google_cloud_sql_mysql",
34+
"--cov-config=.coveragerc",
35+
"tests/",
36+
]
3037
env:
3138
- "PROJECT_ID=$PROJECT_ID"
3239
- "INSTANCE_ID=$_INSTANCE_ID"
@@ -46,7 +53,7 @@ substitutions:
4653
_INSTANCE_ID: test-instance
4754
_REGION: us-central1
4855
_DB_NAME: test
49-
_VERSION: "3.8"
56+
_VERSION: "3.9"
5057

5158
options:
5259
dynamicSubstitutions: true

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ dynamic = ["version"]
44
description = "LangChain integrations for Google Cloud SQL for MySQL"
55
readme = "README.rst"
66
license = {file = "LICENSE"}
7-
requires-python = ">=3.8"
7+
requires-python = ">=3.9"
88
authors = [
99
{name = "Google LLC", email = "googleapis-packages@google.com"}
1010
]
@@ -21,7 +21,6 @@ classifiers = [
2121
"License :: OSI Approved :: Apache Software License",
2222
"Programming Language :: Python",
2323
"Programming Language :: Python :: 3",
24-
"Programming Language :: Python :: 3.8",
2524
"Programming Language :: Python :: 3.9",
2625
"Programming Language :: Python :: 3.10",
2726
"Programming Language :: Python :: 3.11",
@@ -55,7 +54,7 @@ build-backend = "setuptools.build_meta"
5554
profile = "black"
5655

5756
[tool.mypy]
58-
python_version = "3.8"
57+
python_version = "3.9"
5958
warn_unused_configs = true
6059

6160
exclude = [

requirements.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
langchain==0.2.11
22
langchain-community==0.2.9
3-
numpy===1.24.4; python_version <= "3.8"
4-
numpy==1.26.4; python_version > "3.8"
3+
numpy==1.26.4
54
SQLAlchemy==2.0.31
65
cloud-sql-python-connector[pymysql]==1.11.0
76

0 commit comments

Comments
 (0)