feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
sydney-munro added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run sydney-munro force-pushed the custom-metadata branch from f244939 to 621d3a2 Compare 
BenWhitehead requested changes Mar 11, 2024
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
sydney-munro changed the title 
frankyn reviewed Mar 14, 2024
Contributor
frankyn left a comment
frankyn left a comment There was a problem hiding this comment.
LGTM, @BenWhitehead i think is more involved at this point so leaving him to approve.
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
BenWhitehead requested changes Mar 14, 2024
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java Outdated Show resolved Hide resolved
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java Show resolved Hide resolved
...e/src/test/java/com/google/cloud/storage/ParallelCompositeUploadWritableByteChannelTest.java Show resolved Hide resolved
sydney-munro force-pushed the custom-metadata branch from 4d0e172 to 06b5c87 Compare product-auto-label bot added size: l sydney-munro force-pushed the custom-metadata branch 3 times, most recently from 1b963aa to 9bdf885 Compare 
sydney-munro force-pushed the custom-metadata branch from 2bc7c0a to 3236072 Compare BenWhitehead requested changes Mar 15, 2024
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
sydney-munro changed the title 
…at we use to run a PCU
…rallelCompositeUploadBlobWriteSessionConfig.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
sydney-munro force-pushed the custom-metadata branch from 484fc7d to 4861c85 Compare BenWhitehead approved these changes Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.