feat: TPC support #4055
Merged
feat: TPC support #4055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
olavloite reviewed Sep 24, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated Show resolved Hide resolved
...le-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionProperties.java Outdated Show resolved Hide resolved
...e-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ConnectionOptionsTest.java Outdated Show resolved Hide resolved
sakthivelmanii force-pushed the tpc_support branch 4 times, most recently from 486b063 to a160c95 Compare 
sakthivelmanii force-pushed the tpc_support branch from 810aaec to 3656932 Compare olavloite reviewed Sep 24, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated Show resolved Hide resolved
sakthivelmanii force-pushed the tpc_support branch from 1ed1feb to b3ff22d Compare 
sakthivelmanii force-pushed the tpc_support branch from b3ff22d to 1c1756f Compare Comment on lines 88 to 90
| if (monitoringHost != null) { | ||
| settingsBuilder.setEndpoint(monitoringHost); | ||
| } |
There was a problem hiding this comment.
If monitoring host is marked as deprecated, we could remove this and have an alternate option for setting a system property to set monitoring host for testing.
There was a problem hiding this comment.
@Deprecated annotation means it will not remove the functionality. That's why I intend to keep this. Will remove it as part of removal.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Show resolved Hide resolved
surbhigarg92 approved these changes Sep 24, 2025
olavloite approved these changes Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the support for configuring Partner Universe(TPU) in Java Spanner Client Library.
setMonitoringHostmethod which is no longer needed. TPC is not live yet so this functionality was not used.