fix: only close and return sessions once #3846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m product-auto-label bot added size: s 
rahul2393 approved these changes Apr 30, 2025
Closing a pooled session multiple times would cause it to be added to the pool multiple times. This fix prevents this by keeping track of the state of a session that has been checked out.
olavloite force-pushed the only-close-session-once branch from 6b0ae6a to a2fc47b Compare product-auto-label bot added size: m 
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 9, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.92.0` -> `6.93.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.93.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6930-2025-05-09) ##### Features - Enable AFE and gRPC metrics for DP ([#​3852](googleapis/java-spanner#3852)) ([203baae](googleapis/java-spanner@203baae)) ##### Bug Fixes - Change server timing duration attribute to float as per w3c ([#​3851](googleapis/java-spanner#3851)) ([da8dd8d](googleapis/java-spanner@da8dd8d)) - **deps:** Update the Java code generator (gapic-generator-java) to 2.57.0 ([23b985c](googleapis/java-spanner@23b985c)) - Non-ASCII Unicode characters in code ([#​3844](googleapis/java-spanner#3844)) ([85a0820](googleapis/java-spanner@85a0820)) - Only close and return sessions once ([#​3846](googleapis/java-spanner#3846)) ([32b2373](googleapis/java-spanner@32b2373)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bcf762c4aff746876d98c5fcd10f568fa9f00651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closing a pooled session multiple times would cause it to be added to the pool multiple times. This fix prevents this by keeping track of the state of a session that has been checked out.