feat: add support for UpdateDatabase in Cloud Spanner #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
rajatbhatta reviewed Feb 7, 2023
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Show resolved Hide resolved
| @aayushimalik: Can you please add unit tests for the handwritten changes as well (in addition to the integration test you've added)? |
| Please create a separate PR for samples and sample tests for Drop Database Protection. |
…anner-update-database # Conflicts: # google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java
product-auto-label bot added size: l 
rajatbhatta changed the title rajatbhatta changed the title rajatbhatta reviewed Apr 4, 2023
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
rajatbhatta reviewed Apr 4, 2023
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
rajatbhatta reviewed Apr 4, 2023
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
rajatbhatta reviewed Apr 4, 2023
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
rajatbhatta reviewed Apr 11, 2023
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
rajatbhatta approved these changes Apr 17, 2023
There was a problem hiding this comment.
@aayushimalik: Thank you for your patience with me on this PR. LGTM.
rajatbhatta added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run rajatbhatta added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run rajatbhatta added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run rajatbhatta added the owlbot:run gcf-owl-bot bot removed the owlbot:run rajatbhatta added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.