fix: PostgreSQL parser should not treat \ as an escape char #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The PostgreSQL parser that removes comments and checks the type of statement should not consider a backslash inside a quoted literal or identifier as an escape character. Instead, only double occurrences of the same quotes as the begin/end quote should be considered as an escape inside a quoted literal or identifier. Fixes #1920
product-auto-label bot added size: m 
thiagotnunes approved these changes Jun 22, 2022
olavloite added automerge 
yoshi-kokoro removed the kokoro:force-run 
ansh0l approved these changes Jun 22, 2022
olavloite added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
gcf-merge-on-green bot removed the automerge 
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 22, 2022
🤖 I have created a release *beep* *boop* --- ## [6.25.6](v6.25.5...v6.25.6) (2022-06-22) ### Bug Fixes * PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920) ### Documentation * **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4)) ### Dependencies * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Jan 30, 2024
…nfig artifact (#1921) chore: update renovate bot configs to update the sdk-platform-java-config artifact Source-Link: googleapis/synthtool@d7828c0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:0d1bb26a1a99ae0456176bf891b8490e9aab424a5cb4e4d301d9703c4dc43b58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The PostgreSQL parser that removes comments and checks the type of
statement should not consider a backslash inside a quoted literal or
identifier as an escape character. Instead, only double occurrences of
the same quotes as the begin/end quote should be considered as an escape
inside a quoted literal or identifier.
Fixes #1920