Skip to content

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented May 27, 2022

Follow-up to #1858

@mpeddada1 mpeddada1 requested a review from a team as a code owner May 27, 2022 19:15
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels May 27, 2022
@mpeddada1 mpeddada1 requested a review from a team May 27, 2022 19:15
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented May 27, 2022

Hi @ansh0l @rajatbhatta @olavloite could we please get your review on this?

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@blakeli0 blakeli0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@mpeddada1
Copy link
Contributor Author

com.google.cloud.spanner.it.ITInstanceAdminTest seems a little flaky

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@mpeddada1
Copy link
Contributor Author

This configuration has also been tested against: googleapis/java-spanner-jdbc#809 (comment)

Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mpeddada1
Copy link
Contributor Author

Thank you!

@mpeddada1 mpeddada1 merged commit 86895b7 into main May 31, 2022
@mpeddada1 mpeddada1 deleted the add-explain-config branch May 31, 2022 13:13
gcf-merge-on-green bot pushed a commit that referenced this pull request May 31, 2022
🤖 I have created a release *beep* *boop* --- ## [6.25.5](v6.25.4...v6.25.5) (2022-05-31) ### Bug Fixes * add configurations for Explain feature ([#1899](#1899)) ([86895b7](86895b7)) * gracefully ignore RejectedExecutionException during Connection#close() ([#1887](#1887)) ([091bd1d](091bd1d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

5 participants