chore: deduplicate code for batch updates (#2591)

* chore: deduplicate code for batch updates De-duplicate code that is equal for both the sync and async version of the executeBatchUpdate methods. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: olavloite

google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionImpl.java

@@ -1324,32 +1324,15 @@ public ResultSet analyzeUpdateStatement(
 
  @Override
  public long[] executeBatchUpdate(Iterable<Statement> updates) {
- Preconditions.checkNotNull(updates);
- ConnectionPreconditions.checkState(!isClosed(), CLOSED_ERROR_MSG);
- // Check that there are only DML statements in the input.
- List<ParsedStatement> parsedStatements = new LinkedList<>();
- for (Statement update : updates) {
- ParsedStatement parsedStatement = getStatementParser().parse(update);
- switch (parsedStatement.getType()) {
- case UPDATE:
- parsedStatements.add(parsedStatement);
- break;
- case CLIENT_SIDE:
- case QUERY:
- case DDL:
- case UNKNOWN:
- default:
- throw SpannerExceptionFactory.newSpannerException(
- ErrorCode.INVALID_ARGUMENT,
- "The batch update list contains a statement that is not an update statement: "
- + parsedStatement.getSqlWithoutComments());
- }
- }
- return get(internalExecuteBatchUpdateAsync(CallType.SYNC, parsedStatements));
+ return get(internalExecuteBatchUpdateAsync(CallType.SYNC, parseUpdateStatements(updates)));
  }
 
  @Override
  public ApiFuture<long[]> executeBatchUpdateAsync(Iterable<Statement> updates) {
+ return internalExecuteBatchUpdateAsync(CallType.ASYNC, parseUpdateStatements(updates));
+ }
+
+ private List<ParsedStatement> parseUpdateStatements(Iterable<Statement> updates) {
  Preconditions.checkNotNull(updates);
  ConnectionPreconditions.checkState(!isClosed(), CLOSED_ERROR_MSG);
  // Check that there are only DML statements in the input.
@@ -1371,7 +1354,7 @@ public ApiFuture<long[]> executeBatchUpdateAsync(Iterable<Statement> updates) {
  + parsedStatement.getSqlWithoutComments());
  }
  }
- return internalExecuteBatchUpdateAsync(CallType.ASYNC, parsedStatements);
+ return parsedStatements;
  }
 
  private QueryOption[] mergeDataBoost(QueryOption... options) {