fix: getting resultset metadata twice could skip row #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the client application would call ResultSet#getMetaData() more than once **before** calling ResultSet#next(), the ResultSet would skip a row when the rows would be consumed. Fixes #322
product-auto-label bot added the api: spanner 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #323 +/- ## ============================================ + Coverage 70.93% 70.99% +0.05% - Complexity 1105 1107 +2 ============================================ Files 24 24 Lines 3423 3423 Branches 526 526 ============================================ + Hits 2428 2430 +2 + Misses 780 778 -2 Partials 215 215
Continue to review full report at Codecov.
|
thiagotnunes approved these changes Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the client application would call
ResultSet#getMetaData()more than once before callingResultSet#next(), theResultSetwould skip a row when the rows would be consumed.Fixes #322