Skip to content

Commit b162e2a

Browse files
authored
feat: update DatabaseMetaData to include named schemas (#1733)
1 parent 5dbf223 commit b162e2a

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -419,27 +419,27 @@ public String getCatalogSeparator() {
419419

420420
@Override
421421
public boolean supportsSchemasInDataManipulation() {
422-
return false;
422+
return true;
423423
}
424424

425425
@Override
426426
public boolean supportsSchemasInProcedureCalls() {
427-
return false;
427+
return true;
428428
}
429429

430430
@Override
431431
public boolean supportsSchemasInTableDefinitions() {
432-
return false;
432+
return true;
433433
}
434434

435435
@Override
436436
public boolean supportsSchemasInIndexDefinitions() {
437-
return false;
437+
return true;
438438
}
439439

440440
@Override
441441
public boolean supportsSchemasInPrivilegeDefinitions() {
442-
return false;
442+
return true;
443443
}
444444

445445
@Override
@@ -602,7 +602,7 @@ public int getMaxIndexLength() {
602602

603603
@Override
604604
public int getMaxSchemaNameLength() {
605-
return 0;
605+
return 128;
606606
}
607607

608608
@Override

src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public void testTrivialMethods() throws SQLException {
112112
assertEquals(8000, meta.getMaxIndexLength());
113113
assertEquals(0, meta.getMaxProcedureNameLength());
114114
assertEquals(0, meta.getMaxRowSize());
115-
assertEquals(0, meta.getMaxSchemaNameLength());
115+
assertEquals(128, meta.getMaxSchemaNameLength());
116116
assertEquals(1000000, meta.getMaxStatementLength());
117117
assertEquals(0, meta.getMaxStatements());
118118
assertEquals(128, meta.getMaxTableNameLength());
@@ -245,11 +245,11 @@ public void testTrivialMethods() throws SQLException {
245245
assertTrue(meta.supportsResultSetHoldability(ResultSet.CLOSE_CURSORS_AT_COMMIT));
246246
assertFalse(meta.supportsResultSetHoldability(ResultSet.HOLD_CURSORS_OVER_COMMIT));
247247
assertFalse(meta.supportsSavepoints());
248-
assertFalse(meta.supportsSchemasInDataManipulation());
249-
assertFalse(meta.supportsSchemasInIndexDefinitions());
250-
assertFalse(meta.supportsSchemasInPrivilegeDefinitions());
251-
assertFalse(meta.supportsSchemasInProcedureCalls());
252-
assertFalse(meta.supportsSchemasInTableDefinitions());
248+
assertTrue(meta.supportsSchemasInDataManipulation());
249+
assertTrue(meta.supportsSchemasInIndexDefinitions());
250+
assertTrue(meta.supportsSchemasInPrivilegeDefinitions());
251+
assertTrue(meta.supportsSchemasInProcedureCalls());
252+
assertTrue(meta.supportsSchemasInTableDefinitions());
253253
assertFalse(meta.supportsSelectForUpdate());
254254
assertFalse(meta.supportsStatementPooling());
255255
assertFalse(meta.supportsStoredFunctionsUsingCallSyntax());

0 commit comments

Comments
 (0)