Skip to content

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Sep 16, 2021

This PR introduces Maven project and Kokoro configuration for GraalVM native image testing.

With guidance from @lesv and @Neenu1995, our plan is to introduce changes that will be no-op (these change should not affect existing projects) while allowing individual repositories to opt-in GraalVM testing.

Summary of the changes proposed:

  • pom.xml - Adds an additional Maven profile (named native) which contains the dependencies and plugins to run all unit and integration tests compiled with GraalVM with a single command (mvn test -Pnative -Penable-integration-tests). This should also be a transparent change for existing projects as the changes are only enabled with activation of the profile.

A demo of this performed on the Secret Manager repo: googleapis/java-secretmanager#583

cc/ @suztomo

@dzou dzou requested a review from a team as a code owner September 16, 2021 22:16
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2021
@dzou dzou changed the title Introduce job configuration for GraalVM integration testing feat: introduce Maven configuration for GraalVM integration testing Sep 16, 2021
@dzou dzou changed the title feat: introduce Maven configuration for GraalVM integration testing feat: introduce Maven configuration for GraalVM testing Sep 16, 2021
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve w/ question

pom.xml Outdated
Comment on lines 844 to 851
<repositories>
<repository>
<id>snapshots-repo</id>
<url>https://google.oss.sonatype.org/content/repositories/snapshots</url>
<releases><enabled>false</enabled></releases>
<snapshots><enabled>true</enabled></snapshots>
</repository>
</repositories>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just use the -Pallow-snapshots

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I removed this. We will no longer be using snapshots as we will try to eventually pursue putting configuration into java-core or one of the shared dependencies.

@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2021
@Neenu1995
Copy link
Contributor

Waiting to change the artifact name before merging.

@dzou dzou added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 7, 2021
@dzou
Copy link
Contributor Author

dzou commented Oct 7, 2021

Waiting to change the artifact name before merging.

Artifact renamed to native-image-support and updated in this commit: 7926bd4

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@dzou dzou merged commit 28fbeb8 into googleapis:main Oct 7, 2021
@dzou dzou deleted the graalvm-testing branch October 7, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants