Skip to content

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Dec 7, 2021

Update comments to indicate that topics may belong to a region or zone.

@tmdiep tmdiep requested a review from a team as a code owner December 7, 2021 05:35
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 7, 2021
@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2021
@anguillanneuf
Copy link
Contributor

@tmdiep Appears to have some lint complaints.

@tmdiep
Copy link
Contributor Author

tmdiep commented Dec 16, 2021

@anguillanneuf Thanks! Fixed.

@anguillanneuf anguillanneuf self-requested a review January 6, 2022 18:50
@tmdiep tmdiep added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2022
@tmdiep tmdiep requested a review from a team as a code owner February 3, 2022 02:43
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2022
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2022
@tmdiep tmdiep force-pushed the regional_topics_comments branch from cb41221 to 59b7647 Compare February 3, 2022 03:50
@tmdiep tmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2022
@tmdiep tmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2022
@tmdiep tmdiep merged commit 7220439 into googleapis:main Feb 3, 2022
@tmdiep tmdiep deleted the regional_topics_comments branch February 3, 2022 07:13
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 4, 2022
🤖 I have created a release *beep* *boop* --- ### [1.4.9](v1.4.8...v1.4.9) (2022-02-04) ### Bug Fixes * Ensure messages are delivered in order ([#1031](#1031)) ([a8a969e](a8a969e)) * mitigate gRPC stream connection issues ([#1038](#1038)) ([f3678b7](f3678b7)) * Reinitialize streams in an unbounded executor ([#1027](#1027)) ([6377c1d](6377c1d)) ### Documentation * Update comments for regional topics ([#967](#967)) ([7220439](7220439)) ### Dependencies * update dependency com.google.cloud:google-cloud-bom to v0.166.0 ([#1017](#1017)) ([03ae03a](03ae03a)) * update dependency com.google.cloud:google-cloud-pubsub to v1.115.1 ([#1014](#1014)) ([59e74c9](59e74c9)) * update dependency com.google.cloud:google-cloud-pubsub to v1.115.2 ([#1041](#1041)) ([1f46ca9](1f46ca9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1037](#1037)) ([15d4215](15d4215)) * update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#1032](#1032)) ([677b96b](677b96b)) * update dependency com.google.errorprone:error_prone_core to v2.11.0 ([#1033](#1033)) ([088cc62](088cc62)) * update dependency org.checkerframework:checker-qual to v3.21.1 ([#1015](#1015)) ([ffa1f0b](ffa1f0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API.

4 participants