Skip to content

feat: add ReadOption.ReadTime to support timestamp reads. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 23, 2022
Merged

feat: add ReadOption.ReadTime to support timestamp reads. #712

merged 10 commits into from
May 23, 2022

Conversation

yixiaoshen
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@yixiaoshen yixiaoshen requested review from a team as code owners April 18, 2022 18:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Apr 18, 2022
kolea2
kolea2 reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can we also add an integration test?
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 19, 2022
@yixiaoshen yixiaoshen requested a review from kolea2 May 20, 2022 18:17
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label May 23, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 06bb08f into googleapis:main May 23, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 23, 2022
@release-please release-please bot mentioned this pull request May 23, 2022
Merged
@yixiaoshen yixiaoshen deleted the ys-snapshot-read-v1 branch May 23, 2022 19:18
gcf-merge-on-green bot pushed a commit that referenced this pull request May 23, 2022
@release-please
chore(main): release 2.5.0 (#729)
c04b37e 
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2022-05-23) ### Features * add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#739](#739)) ([252a174](252a174)) * add ReadOption.ReadTime to support timestamp reads. ([#712](#712)) ([06bb08f](06bb08f)) ### Bug Fixes * **java:** rename test to be picked up by native profile ([#723](#723)) ([3a30e75](3a30e75)) ### Documentation * **samples:** remove unused dependency ([#730](#730)) ([5185691](5185691)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#737](#737)) ([8eb0c5f](8eb0c5f)) * update shared deps to 2.12.0 ([#740](#740)) ([5c3676e](5c3676e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.

3 participants

@yixiaoshen @kolea2 @yoshi-kokoro