feat(bigtable): Add schema bundle support #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: l product-auto-label bot added size: xl | /gcbrun |
andre-sampaio added kokoro:run andre-sampaio added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run | * | ||
| * @see SchemaBundleType for details. | ||
| */ | ||
| public CreateSchemaBundleRequest setProtoSchema(@Nonnull String protoSchemaFile) |
There was a problem hiding this comment.
Is it ever valid for a request not to have a protoSchema set? Otherwise we may want to either make it a required argument for creating a CreateSchemaBundleRequest or validate it before converting it to proto
It also feels like requiring a file path is overly restrictive (what if the file is on gcs / some database / etc). Can we accept a string and provide a utility method to read from a file instead if we think that's important (e.g. setProtoSchemaFromFile(Path file))
There was a problem hiding this comment.
We do the same for views and their queries, so I don't think we want to move the protoSchemaFile to the ctor, for consistency.
We could support accept the file contents as byte array, and have the caller get these bytes from anywhere.
| /** Gets the schema bundle's id. */ | ||
| public String getId() { | ||
| // Constructor ensures that name is not null. | ||
| SchemaBundleName fullName = SchemaBundleName.parse(proto.getName()); |
There was a problem hiding this comment.
NIT: we can store the parsed SchemaBundleName as an instance member in the constructor
| } | ||
| | ||
| /** Changes the deletion protection of an existing schema bundle. */ | ||
| public UpdateSchemaBundleRequest setProtoSchema(String protoSchemaFile) throws IOException { |
There was a problem hiding this comment.
Same comment as from CreateSchemaBundleRequest
andre-sampaio previously approved these changes Jul 8, 2025
andre-sampaio added kokoro:run yoshi-kokoro removed the kokoro:run andre-sampaio approved these changes Jul 9, 2025
gcf-merge-on-green bot removed the automerge 
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [2.62.0](https://togithub.com/googleapis/java-bigtable/compare/v2.61.0...v2.62.0) (2025-07-15) ### Features * Add Idempotency to Cloud Bigtable MutateRowRequest API ([b5acca6](https://togithub.com/googleapis/java-bigtable/commit/b5acca6ac4f1eec420adb27bc77aa1bda0ec2dca)) * Add SchemaBundles API ([b5acca6](https://togithub.com/googleapis/java-bigtable/commit/b5acca6ac4f1eec420adb27bc77aa1bda0ec2dca)) * **bigtable:** Add schema bundle support ([#2619](https://togithub.com/googleapis/java-bigtable/issues/2619)) ([7d7b9a9](https://togithub.com/googleapis/java-bigtable/commit/7d7b9a966d3ef7b7a0ef3f82038ab73f4d791427)) * Next release from main branch is 2.62.0 ([#2621](https://togithub.com/googleapis/java-bigtable/issues/2621)) ([202b211](https://togithub.com/googleapis/java-bigtable/commit/202b21102e71da71ff56f19a12d8a00a59cd8107)) ### Dependencies * Minor cleanup ([#2623](https://togithub.com/googleapis/java-bigtable/issues/2623)) ([7b230e8](https://togithub.com/googleapis/java-bigtable/commit/7b230e86902b5733c06e45fad90da76653ee1096)) * Update shared dependencies ([#2616](https://togithub.com/googleapis/java-bigtable/issues/2616)) ([eb7cfd5](https://togithub.com/googleapis/java-bigtable/commit/eb7cfd526aa999c614b7b8285d32759e2739ff9a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
nicholsl pushed a commit to nicholsl/java-bigtable that referenced this pull request Jul 16, 2025
* feat(bigtable): Add schema bundle support * minor fix * fix format * add tests * add tests * handled file * added files * fix format * fix files * fix comment * fix * fix test * fix test * fix test * fix more tests * fix more tests * fix more tests * fix more tests * fix more tests * use separate tables for tests * use separate tables for tests * use separate tables for tests * update according to PR * update according to PR * update according to PR * Update UpdateSchemaBundleRequest.java * fix build
nicholsl pushed a commit to nicholsl/java-bigtable that referenced this pull request Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [2.62.0](https://togithub.com/googleapis/java-bigtable/compare/v2.61.0...v2.62.0) (2025-07-15) ### Features * Add Idempotency to Cloud Bigtable MutateRowRequest API ([b5acca6](https://togithub.com/googleapis/java-bigtable/commit/b5acca6ac4f1eec420adb27bc77aa1bda0ec2dca)) * Add SchemaBundles API ([b5acca6](https://togithub.com/googleapis/java-bigtable/commit/b5acca6ac4f1eec420adb27bc77aa1bda0ec2dca)) * **bigtable:** Add schema bundle support ([googleapis#2619](https://togithub.com/googleapis/java-bigtable/issues/2619)) ([7d7b9a9](https://togithub.com/googleapis/java-bigtable/commit/7d7b9a966d3ef7b7a0ef3f82038ab73f4d791427)) * Next release from main branch is 2.62.0 ([googleapis#2621](https://togithub.com/googleapis/java-bigtable/issues/2621)) ([202b211](https://togithub.com/googleapis/java-bigtable/commit/202b21102e71da71ff56f19a12d8a00a59cd8107)) ### Dependencies * Minor cleanup ([googleapis#2623](https://togithub.com/googleapis/java-bigtable/issues/2623)) ([7b230e8](https://togithub.com/googleapis/java-bigtable/commit/7b230e86902b5733c06e45fad90da76653ee1096)) * Update shared dependencies ([googleapis#2616](https://togithub.com/googleapis/java-bigtable/issues/2616)) ([eb7cfd5](https://togithub.com/googleapis/java-bigtable/commit/eb7cfd526aa999c614b7b8285d32759e2739ff9a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.