fix: allow factory to export to different projects #2374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s product-auto-label bot added size: m 
igorbernstein2 requested changes Oct 16, 2024
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java Show resolved Hide resolved
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java Show resolved Hide resolved
...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java Show resolved Hide resolved
product-auto-label bot added size: l 
mutianf force-pushed the factory branch 2 times, most recently from 2ef6d06 to fbb5135 Compare 
| Note: global otel is not idea. We should refactor how the client context is created so otel doesn't need to be global. |
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java Outdated Show resolved Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java Show resolved Hide resolved
igorbernstein2 approved these changes Dec 2, 2024
...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java Outdated Show resolved Hide resolved
mutianf added the automerge 
gcf-merge-on-green bot removed the automerge 
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 4, 2024
🤖 I have created a release *beep* *boop* --- ## [2.49.0](https://togithub.com/googleapis/java-bigtable/compare/v2.48.0...v2.49.0) (2024-12-03) ### Features * Add support for table deletion protection ([#2430](https://togithub.com/googleapis/java-bigtable/issues/2430)) ([687b6df](https://togithub.com/googleapis/java-bigtable/commit/687b6df14b743358e8207cda26022dfc75338d55)) ### Bug Fixes * Allow factory to export to different projects ([#2374](https://togithub.com/googleapis/java-bigtable/issues/2374)) ([06b912c](https://togithub.com/googleapis/java-bigtable/commit/06b912cc5d63436757008e79edfa8286b2ccac18)) * Send priming requests on the channel directly ([#2435](https://togithub.com/googleapis/java-bigtable/issues/2435)) ([b76698d](https://togithub.com/googleapis/java-bigtable/commit/b76698dfb2c8552185f34e01e924ecc80798ba4f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fix removed the check on Bigtable project id and gets the BigtableTable resource project id directly from metrics attribute. BigtableDataClientFactory can create one client for multiple projects. Removing the check allows people using BigtableDataClientFactory to export to different projects.